From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751453AbdH3KTF (ORCPT <rfc822;w@1wt.eu>);
        Wed, 30 Aug 2017 06:19:05 -0400
Received: from mga02.intel.com ([134.134.136.20]:20292 "EHLO mga02.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751295AbdH3KTE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 30 Aug 2017 06:19:04 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.41,448,1498546800"; 
   d="scan'208";a="1189746765"
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
        Dmitri Prokhorov <Dmitry.Prohorov@intel.com>,
        Valery Cherepennikov <valery.cherepennikov@intel.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Stephane Eranian <eranian@google.com>,
        David Carrillo-Cisneros <davidcc@google.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/3] perf/core: use rb trees for pinned/flexible groups
In-Reply-To: <fa962d7c-2a6d-bb33-50b0-9d8f0057e8ab@linux.intel.com>
References: <96c7776f-1f17-a39e-23e9-658596216d6b@linux.intel.com> <d98d9399-7292-e14d-5988-adc474f4e54a@linux.intel.com> <20170803130002.oatczvnaalplrsep@hirez.programming.kicks-ass.net> <86cbe0b0-a1ec-4d5f-addc-87bccf2e97d7@linux.intel.com> <20170804143628.34c2xqxl2e6k2arj@hirez.programming.kicks-ass.net> <9d2e25c9-209c-f28a-d601-d3f1a71f032f@linux.intel.com> <c882a2d5-4b76-e838-f812-0b4f70b0e3f7@linux.intel.com> <87lgm2xz0m.fsf@ashishki-desk.ger.corp.intel.com> <fa962d7c-2a6d-bb33-50b0-9d8f0057e8ab@linux.intel.com>
User-Agent: Notmuch/0.23.7 (http://notmuchmail.org) Emacs/25.1.1 (x86_64-pc-linux-gnu)
Date: Wed, 30 Aug 2017 13:18:59 +0300
Message-ID: <87a82hxsrw.fsf@ashishki-desk.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Alexey Budankov <alexey.budankov@linux.intel.com> writes:

>>> Iterating cpu specific subtree like this:
>>>
>>> #define for_each_group_event(event, group, cpu, pmu, field)	 \
>>> 	for (event = rb_entry_safe(group_first(group, cpu, pmu), \
>>> 				   typeof(*event), field);	 \
>>> 	     event && event->cpu == cpu && event->pmu == pmu;	 \
>>> 	     event = rb_entry_safe(rb_next(&event->field),	 \
>>> 				   typeof(*event), field))
>> 
>> Afaict, this assumes that you are also ordering on event->pmu, which
>> should be reflected in your _less function. And also assuming that
>> group_first() is doing the right thing. Can we see the code?
>
> I didn't do ordering by PMU for this patch set. Yet more I implemented 
> groups_first() like this:

Your iterator (quoted above) begs to differ.

Regards,
--
Alex