From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhuDu-0002Y5-5P for qemu-devel@nongnu.org; Wed, 16 Aug 2017 05:02:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhuDt-00081O-GV for qemu-devel@nongnu.org; Wed, 16 Aug 2017 05:02:46 -0400 From: Markus Armbruster References: <20170727154126.11339-1-marcandre.lureau@redhat.com> <20170727154126.11339-3-marcandre.lureau@redhat.com> Date: Wed, 16 Aug 2017 11:02:35 +0200 In-Reply-To: <20170727154126.11339-3-marcandre.lureau@redhat.com> (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Thu, 27 Jul 2017 17:41:02 +0200") Message-ID: <87a82zevh0.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 02/26] qobject: replace dump_qobject() by qobject_to_string() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, Kevin Wolf , "open list:Block layer core" , Max Reitz Marc-Andr=C3=A9 Lureau writes: > The dump functions is generally useful for any qobject user, for > testing, debugging etc. > > The callback-based output is replaced by string allocation. Trading > efficiency for ease-of-use is okay here. > > Signed-off-by: Marc-Andr=C3=A9 Lureau As far as I can tell, this patch is in this series only for the next patch's check-qlit.c. I don't like its use there, so I'm ignoring this patch for now.