From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [RFC i-g-t] igt: Test tagging support
Date: Thu, 29 Jun 2017 12:07:04 +0300 [thread overview]
Message-ID: <87a84rb1s7.fsf@intel.com> (raw)
In-Reply-To: <20170629084909.xisnr222srityav7@phenom.ffwll.local>
On Thu, 29 Jun 2017, Daniel Vetter <daniel@ffwll.ch> wrote:
> Just adding tags because tags sounds like a cool idea on top of all the
> other things we do already still doesn't sound appealing to me.
Agreed.
So I always thought it was silly when we relied on test names to select
tests to run or exclude in the past. I'm equally suspicious of adding
any sorts of categories or tags within the test sources. I don't think a
test source file should be changed if the category changes. Thus I think
maintaining the categories outside of the tests is a good idea.
Currently we maintain the categories as test lists. I think you could
call them tags just as well. Them being lists in files is just an
implementation detail. If a test is included in a test list, then it's
so tagged. If we wanted to, we could add more logic to running the tests
based on which lists the tests are in. For example, "in extended and not
in stress".
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-06-29 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 11:59 [RFC i-g-t] igt: Test tagging support Tvrtko Ursulin
2017-06-27 13:18 ` Daniel Vetter
2017-06-27 14:03 ` Tvrtko Ursulin
2017-06-29 8:49 ` Daniel Vetter
2017-06-29 9:07 ` Jani Nikula [this message]
2017-06-29 9:27 ` Tvrtko Ursulin
2017-06-29 9:23 ` Tvrtko Ursulin
2017-06-29 9:34 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a84rb1s7.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=tomi.p.sarvela@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.