From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934304AbdCVLq0 (ORCPT ); Wed, 22 Mar 2017 07:46:26 -0400 Received: from ozlabs.org ([103.22.144.67]:48033 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934160AbdCVLqO (ORCPT ); Wed, 22 Mar 2017 07:46:14 -0400 From: Michael Ellerman To: Shuah Khan , Bamvor Zhang Jian Cc: Andy Lutomirski , "Zhangjian \(Bamvor\)" , Linux API , "linux-kernel\@vger.kernel.org" , Kevin Hilman , Mark Brown , Shuah Khan Subject: Re: [PATCH v2 6/6] selftests: enable O and KBUILD_OUTPUT In-Reply-To: <5daf0b79-a000-2adb-0b1e-f528d66ff6df@osg.samsung.com> References: <20161129115552.8148-1-bamvor.zhangjian@huawei.com> <20161129115552.8148-7-bamvor.zhangjian@huawei.com> <87fui7owls.fsf@concordia.ellerman.id.au> <5daf0b79-a000-2adb-0b1e-f528d66ff6df@osg.samsung.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Wed, 22 Mar 2017 22:46:11 +1100 Message-ID: <87a88dcz5o.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Shuah Khan writes: > On 03/21/2017 03:00 AM, Bamvor Zhang Jian wrote: >> On 21 March 2017 at 16:35, Michael Ellerman wrote: >>> Andy Lutomirski writes: >>>> On Tue, Nov 29, 2016 at 3:55 AM, wrote: >>>>> From: Bamvor Jian Zhang >>>>> >>>>> Enable O and KBUILD_OUTPUT for kselftest. User could compile kselftest >>>>> to another directory by passing O or KBUILD_OUTPUT. And O is high >>>>> priority than KBUILD_OUTPUT. >>>> >>>> Sorry for noticing this late, but this patch >>>> (a8ba798bc8ec663cf02e80b0dd770324de9bafd9) is really annoying for >>>> people who *don't* use these fancy options: >>> >>> Yeah sorry, it wasn't quite ready to go in. > > Bamovar, > > Please give me heads up and ask me to not commit the patch, > if you think it isn't ready. That was me who wrote that above. >> Do we really need "make -C tools/testing/selftests/x86 ldt_gdt_32"? >> It is useful but it will skip the top level Makefile of selftests. > > Being able to build individual tests is an important use-case. Then it needs to be tested before changes are merged. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [PATCH v2 6/6] selftests: enable O and KBUILD_OUTPUT Date: Wed, 22 Mar 2017 22:46:11 +1100 Message-ID: <87a88dcz5o.fsf@concordia.ellerman.id.au> References: <20161129115552.8148-1-bamvor.zhangjian@huawei.com> <20161129115552.8148-7-bamvor.zhangjian@huawei.com> <87fui7owls.fsf@concordia.ellerman.id.au> <5daf0b79-a000-2adb-0b1e-f528d66ff6df@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <5daf0b79-a000-2adb-0b1e-f528d66ff6df-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bamvor Zhang Jian Cc: Andy Lutomirski , "Zhangjian (Bamvor)" , Linux API , "linux-kernel@vger.kernel.org" , Kevin Hilman , Mark Brown , Shuah Khan List-Id: linux-api@vger.kernel.org Shuah Khan writes: > On 03/21/2017 03:00 AM, Bamvor Zhang Jian wrote: >> On 21 March 2017 at 16:35, Michael Ellerman wrote: >>> Andy Lutomirski writes: >>>> On Tue, Nov 29, 2016 at 3:55 AM, wrote: >>>>> From: Bamvor Jian Zhang >>>>> >>>>> Enable O and KBUILD_OUTPUT for kselftest. User could compile kselftest >>>>> to another directory by passing O or KBUILD_OUTPUT. And O is high >>>>> priority than KBUILD_OUTPUT. >>>> >>>> Sorry for noticing this late, but this patch >>>> (a8ba798bc8ec663cf02e80b0dd770324de9bafd9) is really annoying for >>>> people who *don't* use these fancy options: >>> >>> Yeah sorry, it wasn't quite ready to go in. > > Bamovar, > > Please give me heads up and ask me to not commit the patch, > if you think it isn't ready. That was me who wrote that above. >> Do we really need "make -C tools/testing/selftests/x86 ldt_gdt_32"? >> It is useful but it will skip the top level Makefile of selftests. > > Being able to build individual tests is an important use-case. Then it needs to be tested before changes are merged. cheers