From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044AbdBUKyj (ORCPT ); Tue, 21 Feb 2017 05:54:39 -0500 Received: from mga09.intel.com ([134.134.136.24]:12308 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbdBUKyb (ORCPT ); Tue, 21 Feb 2017 05:54:31 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,189,1484035200"; d="scan'208";a="50704749" From: Alexander Shishkin To: Will Deacon Cc: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Mathieu Poirier Subject: Re: [PATCH 2/4] perf: Keep AUX flags in the output handle In-Reply-To: <20170221104242.GB300@arm.com> References: <20170220133352.17995-1-alexander.shishkin@linux.intel.com> <20170220133352.17995-3-alexander.shishkin@linux.intel.com> <20170221104242.GB300@arm.com> User-Agent: Notmuch/0.23.5 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 21 Feb 2017 12:54:26 +0200 Message-ID: <87a89fizkt.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Will Deacon writes: > Hi Alexander, Hi Will, >> + handle->aux_flags &= ~PERF_AUX_FLAG_OVERWRITE; >> + > > ... I don't think you need this addition anymore. It's harmless, though. Right, assuming the PMU driver isn't doing anything fishy to handle->aux_flags directly. Regards, -- Alex