From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59356)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bn65T-0007Fm-RN
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:39:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bn65P-00060r-ND
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:38:58 -0400
Received: from mail-lf0-f53.google.com ([209.85.215.53]:36252)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bn65P-00060K-0K
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 11:38:55 -0400
Received: by mail-lf0-f53.google.com with SMTP id g62so71519356lfe.3
	for <qemu-devel@nongnu.org>; Thu, 22 Sep 2016 08:38:54 -0700 (PDT)
References: <1473678761-8885-1-git-send-email-pbonzini@redhat.com>
	<1473678761-8885-9-git-send-email-pbonzini@redhat.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1473678761-8885-9-git-send-email-pbonzini@redhat.com>
Date: Thu, 22 Sep 2016 16:37:52 +0100
Message-ID: <87a8f0aqsv.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 08/16] cpus-common: fix uninitialized
 variable use in run_on_cpu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, sergey.fedorov@linaro.org


Paolo Bonzini <pbonzini@redhat.com> writes:

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  cpus-common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cpus-common.c b/cpus-common.c
> index b98f548..cdfdb14 100644
> --- a/cpus-common.c
> +++ b/cpus-common.c
> @@ -88,8 +88,7 @@ struct qemu_work_item {
>      struct qemu_work_item *next;
>      run_on_cpu_func func;
>      void *data;
> -    int done;
> -    bool free;
> +    bool free, done;
>  };
>
>  static void queue_work_on_cpu(CPUState *cpu, struct qemu_work_item *wi)
> @@ -120,6 +119,7 @@ void do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, void *data,
>
>      wi.func = func;
>      wi.data = data;
> +    wi.done = false;
>      wi.free = false;
>
>      queue_work_on_cpu(cpu, &wi);

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

--
Alex Bennée