From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 08/17] drm/i915: Drop spinlocks around adding to the client request list Date: Fri, 26 Aug 2016 12:13:10 +0300 Message-ID: <87a8fzao61.fsf@gaia.fi.intel.com> References: <20160822080350.4964-1-chris@chris-wilson.co.uk> <20160822080350.4964-9-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2D7E86E0D0 for ; Fri, 26 Aug 2016 09:13:54 +0000 (UTC) In-Reply-To: <20160822080350.4964-9-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gQWRkaW5n IHRvIHRoZSB0YWlsIG9mIHRoZSBjbGllbnQgcmVxdWVzdCBsaXN0IGFzIHRoZSBvbmx5IG90aGVy IHVzZXIgaXMKPiBpbiB0aGUgdGhyb3R0bGUgaW9jdGwgdGhhdCBpdGVyYXRlcyBmb3J3YXJkcyBv dmVyIHRoZSBsaXN0LiBJdCBvbmx5Cj4gbmVlZHMgcHJvdGVjdGlvbiBhZ2FpbnN0IGRlbGV0aW9u IG9mIGEgcmVxdWVzdCBhcyBpdCByZWFkcyBpdCwgaXQgc2ltcGx5Cj4gd29uJ3Qgc2VlIGEgbmV3 IHJlcXVlc3QgYWRkZWQgdG8gdGhlIGVuZCBvZiB0aGUgbGlzdCwgb3IgaXQgd291bGQgYmUgdG9v Cj4gZWFybHkgYW5kIHJlamVjdGVkLiBXZSBjYW4gZnVydGhlciByZWR1Y2UgdGhlIG51bWJlciBv ZiBzcGlubG9ja3MKPiByZXF1aXJlZCB3aGVuIHRocm90dGxpbmcgYnkgcmVtb3Zpbmcgc3RhbGUg cmVxdWVzdHMgZnJvbSB0aGUgY2xpZW50X2xpc3QKPiBhcyB3ZSB0aHJvdHRsZS4KPgo+IFNpZ25l ZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgoKUmV2aWV2 ZWQtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAaW50ZWwuY29tPgoKPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgICAgICAgIHwgIDIgKy0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgICAgICAgICAgIHwgMTQgKysrKysrLS0tLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyB8IDE0ICsrKysr KystLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMgICAgfCAz NCArKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fcmVxdWVzdC5oICAgIHwgIDQgKy0tLQo+ICA1IGZpbGVzIGNoYW5nZWQsIDIzIGlu c2VydGlvbnMoKyksIDQ1IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1 Z2ZzLmMKPiBpbmRleCAwODYwNTNmYTI4MjAuLjk5Njc0NDcwOGYzMSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gQEAgLTQ4MCw3ICs0ODAsNyBAQCBzdGF0aWMgaW50IGk5 MTVfZ2VtX29iamVjdF9pbmZvKHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCogZGF0YSkKPiAgCQlt dXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gIAkJcmVxdWVzdCA9IGxpc3RfZmlyc3Rf ZW50cnlfb3JfbnVsbCgmZmlsZV9wcml2LT5tbS5yZXF1ZXN0X2xpc3QsCj4gIAkJCQkJCSAgIHN0 cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCwKPiAtCQkJCQkJICAgY2xpZW50X2xpc3QpOwo+ICsJ CQkJCQkgICBjbGllbnRfbGluayk7Cj4gIAkJcmN1X3JlYWRfbG9jaygpOwo+ICAJCXRhc2sgPSBw aWRfdGFzayhyZXF1ZXN0ICYmIHJlcXVlc3QtPmN0eC0+cGlkID8KPiAgCQkJCXJlcXVlc3QtPmN0 eC0+cGlkIDogZmlsZS0+cGlkLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IDdiOGFi ZGE1NDFlNi4uZTQzMjIxMWU4YjI0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAg LTM2NzMsMTYgKzM2NzMsMTQgQEAgaTkxNV9nZW1fcmluZ190aHJvdHRsZShzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpCj4gIAkJcmV0dXJuIC1FSU87Cj4gIAo+ ICAJc3Bpbl9sb2NrKCZmaWxlX3ByaXYtPm1tLmxvY2spOwo+IC0JbGlzdF9mb3JfZWFjaF9lbnRy eShyZXF1ZXN0LCAmZmlsZV9wcml2LT5tbS5yZXF1ZXN0X2xpc3QsIGNsaWVudF9saXN0KSB7Cj4g KwlsaXN0X2Zvcl9lYWNoX2VudHJ5KHJlcXVlc3QsICZmaWxlX3ByaXYtPm1tLnJlcXVlc3RfbGlz dCwgY2xpZW50X2xpbmspIHsKPiAgCQlpZiAodGltZV9hZnRlcl9lcShyZXF1ZXN0LT5lbWl0dGVk X2ppZmZpZXMsIHJlY2VudF9lbm91Z2gpKQo+ICAJCQlicmVhazsKPiAgCj4gLQkJLyoKPiAtCQkg KiBOb3RlIHRoYXQgdGhlIHJlcXVlc3QgbWlnaHQgbm90IGhhdmUgYmVlbiBzdWJtaXR0ZWQgeWV0 Lgo+IC0JCSAqIEluIHdoaWNoIGNhc2UgZW1pdHRlZF9qaWZmaWVzIHdpbGwgYmUgemVyby4KPiAt CQkgKi8KPiAtCQlpZiAoIXJlcXVlc3QtPmVtaXR0ZWRfamlmZmllcykKPiAtCQkJY29udGludWU7 Cj4gKwkJaWYgKHRhcmdldCkgewo+ICsJCQlsaXN0X2RlbCgmdGFyZ2V0LT5jbGllbnRfbGluayk7 Cj4gKwkJCXRhcmdldC0+ZmlsZV9wcml2ID0gTlVMTDsKPiArCQl9Cj4gIAo+ICAJCXRhcmdldCA9 IHJlcXVlc3Q7Cj4gIAl9Cj4gQEAgLTQ2MzksNyArNDYzNyw3IEBAIHZvaWQgaTkxNV9nZW1fcmVs ZWFzZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpCj4gIAkg KiBmaWxlX3ByaXYuCj4gIAkgKi8KPiAgCXNwaW5fbG9jaygmZmlsZV9wcml2LT5tbS5sb2NrKTsK PiAtCWxpc3RfZm9yX2VhY2hfZW50cnkocmVxdWVzdCwgJmZpbGVfcHJpdi0+bW0ucmVxdWVzdF9s aXN0LCBjbGllbnRfbGlzdCkKPiArCWxpc3RfZm9yX2VhY2hfZW50cnkocmVxdWVzdCwgJmZpbGVf cHJpdi0+bW0ucmVxdWVzdF9saXN0LCBjbGllbnRfbGluaykKPiAgCQlyZXF1ZXN0LT5maWxlX3By aXYgPSBOVUxMOwo+ICAJc3Bpbl91bmxvY2soJmZpbGVfcHJpdi0+bW0ubG9jayk7Cj4gIAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiBpbmRleCAxMjVmYjM4 ZWZmNDAuLjU2ODk0NDViMWNkMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbV9leGVjYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bV9leGVjYnVmZmVyLmMKPiBAQCAtMTQyMSw2ICsxNDIxLDE0IEBAIG91dDoKPiAgCXJldHVybiB2 bWE7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkCj4gK2FkZF90b19jbGllbnQoc3RydWN0IGRybV9p OTE1X2dlbV9yZXF1ZXN0ICpyZXEsCj4gKwkgICAgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpCj4g K3sKPiArCXJlcS0+ZmlsZV9wcml2ID0gZmlsZS0+ZHJpdmVyX3ByaXY7Cj4gKwlsaXN0X2FkZF90 YWlsKCZyZXEtPmNsaWVudF9saW5rLCAmcmVxLT5maWxlX3ByaXYtPm1tLnJlcXVlc3RfbGlzdCk7 Cj4gK30KPiArCj4gIHN0YXRpYyBpbnQKPiAgZXhlY2J1Zl9zdWJtaXQoc3RydWN0IGk5MTVfZXhl Y2J1ZmZlcl9wYXJhbXMgKnBhcmFtcywKPiAgCSAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2V4 ZWNidWZmZXIyICphcmdzLAo+IEBAIC0xNTEyLDYgKzE1MjAsNyBAQCBleGVjYnVmX3N1Ym1pdChz dHJ1Y3QgaTkxNV9leGVjYnVmZmVyX3BhcmFtcyAqcGFyYW1zLAo+ICAJdHJhY2VfaTkxNV9nZW1f cmluZ19kaXNwYXRjaChwYXJhbXMtPnJlcXVlc3QsIHBhcmFtcy0+ZGlzcGF0Y2hfZmxhZ3MpOwo+ ICAKPiAgCWk5MTVfZ2VtX2V4ZWNidWZmZXJfbW92ZV90b19hY3RpdmUodm1hcywgcGFyYW1zLT5y ZXF1ZXN0KTsKPiArCWFkZF90b19jbGllbnQocGFyYW1zLT5yZXF1ZXN0LCBwYXJhbXMtPmZpbGUp Owo+ICAKPiAgCXJldHVybiAwOwo+ICB9Cj4gQEAgLTE4MDgsMTAgKzE4MTcsNiBAQCBpOTE1X2dl bV9kb19leGVjYnVmZmVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAkg Ki8KPiAgCXBhcmFtcy0+cmVxdWVzdC0+YmF0Y2ggPSBwYXJhbXMtPmJhdGNoOwo+ICAKPiAtCXJl dCA9IGk5MTVfZ2VtX3JlcXVlc3RfYWRkX3RvX2NsaWVudChwYXJhbXMtPnJlcXVlc3QsIGZpbGUp Owo+IC0JaWYgKHJldCkKPiAtCQlnb3RvIGVycl9yZXF1ZXN0Owo+IC0KPiAgCS8qCj4gIAkgKiBT YXZlIGFzc29ydGVkIHN0dWZmIGF3YXkgdG8gcGFzcyB0aHJvdWdoIHRvICpfc3VibWlzc2lvbigp Lgo+ICAJICogTkI6IFRoaXMgZGF0YSBzaG91bGQgYmUgJ3BlcnNpc3RlbnQnIGFuZCBub3QgbG9j YWwgYXMgaXQgd2lsbAo+IEBAIC0xODI1LDcgKzE4MzAsNiBAQCBpOTE1X2dlbV9kb19leGVjYnVm ZmVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAlwYXJhbXMtPmN0eCAg ICAgICAgICAgICAgICAgICAgID0gY3R4Owo+ICAKPiAgCXJldCA9IGV4ZWNidWZfc3VibWl0KHBh cmFtcywgYXJncywgJmViLT52bWFzKTsKPiAtZXJyX3JlcXVlc3Q6Cj4gIAlfX2k5MTVfYWRkX3Jl cXVlc3QocGFyYW1zLT5yZXF1ZXN0LCByZXQgPT0gMCk7Cj4gIAo+ICBlcnJfYmF0Y2hfdW5waW46 Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYwo+IGluZGV4IDFhMjE1MzIw Y2VmYi4uYmY2MjQyN2EzNWI3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtX3JlcXVlc3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3Jl cXVlc3QuYwo+IEBAIC0xMTUsNDIgKzExNSwyMCBAQCBjb25zdCBzdHJ1Y3QgZmVuY2Vfb3BzIGk5 MTVfZmVuY2Vfb3BzID0gewo+ICAJLnRpbWVsaW5lX3ZhbHVlX3N0ciA9IGk5MTVfZmVuY2VfdGlt ZWxpbmVfdmFsdWVfc3RyLAo+ICB9Owo+ICAKPiAtaW50IGk5MTVfZ2VtX3JlcXVlc3RfYWRkX3Rv X2NsaWVudChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPiAtCQkJCSAgIHN0cnVj dCBkcm1fZmlsZSAqZmlsZSkKPiAtewo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2YXRlOwo+IC0Jc3RydWN0IGRybV9pOTE1X2ZpbGVfcHJpdmF0ZSAqZmlsZV9wcml2Owo+IC0K PiAtCVdBUk5fT04oIXJlcSB8fCAhZmlsZSB8fCByZXEtPmZpbGVfcHJpdik7Cj4gLQo+IC0JaWYg KCFyZXEgfHwgIWZpbGUpCj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQo+IC0JaWYgKHJlcS0+Zmls ZV9wcml2KQo+IC0JCXJldHVybiAtRUlOVkFMOwo+IC0KPiAtCWRldl9wcml2YXRlID0gcmVxLT5p OTE1Owo+IC0JZmlsZV9wcml2ID0gZmlsZS0+ZHJpdmVyX3ByaXY7Cj4gLQo+IC0Jc3Bpbl9sb2Nr KCZmaWxlX3ByaXYtPm1tLmxvY2spOwo+IC0JcmVxLT5maWxlX3ByaXYgPSBmaWxlX3ByaXY7Cj4g LQlsaXN0X2FkZF90YWlsKCZyZXEtPmNsaWVudF9saXN0LCAmZmlsZV9wcml2LT5tbS5yZXF1ZXN0 X2xpc3QpOwo+IC0Jc3Bpbl91bmxvY2soJmZpbGVfcHJpdi0+bW0ubG9jayk7Cj4gLQo+IC0JcmV0 dXJuIDA7Cj4gLX0KPiAtCj4gIHN0YXRpYyBpbmxpbmUgdm9pZAo+ICBpOTE1X2dlbV9yZXF1ZXN0 X3JlbW92ZV9mcm9tX2NsaWVudChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3Qp Cj4gIHsKPiAtCXN0cnVjdCBkcm1faTkxNV9maWxlX3ByaXZhdGUgKmZpbGVfcHJpdiA9IHJlcXVl c3QtPmZpbGVfcHJpdjsKPiArCXN0cnVjdCBkcm1faTkxNV9maWxlX3ByaXZhdGUgKmZpbGVfcHJp djsKPiAgCj4gKwlmaWxlX3ByaXYgPSByZXF1ZXN0LT5maWxlX3ByaXY7Cj4gIAlpZiAoIWZpbGVf cHJpdikKPiAgCQlyZXR1cm47Cj4gIAo+ICAJc3Bpbl9sb2NrKCZmaWxlX3ByaXYtPm1tLmxvY2sp Owo+IC0JbGlzdF9kZWwoJnJlcXVlc3QtPmNsaWVudF9saXN0KTsKPiAtCXJlcXVlc3QtPmZpbGVf cHJpdiA9IE5VTEw7Cj4gKwlpZiAocmVxdWVzdC0+ZmlsZV9wcml2KSB7Cj4gKwkJbGlzdF9kZWwo JnJlcXVlc3QtPmNsaWVudF9saW5rKTsKPiArCQlyZXF1ZXN0LT5maWxlX3ByaXYgPSBOVUxMOwo+ ICsJfQo+ICAJc3Bpbl91bmxvY2soJmZpbGVfcHJpdi0+bW0ubG9jayk7Cj4gIH0KPiAgCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuaCBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuaAo+IGluZGV4IDZjNzJiZDhkOTQyMy4u OWQ1YTY2YmZjNTA5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt X3JlcXVlc3QuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3Qu aAo+IEBAIC0xMzIsNyArMTMyLDcgQEAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0IHsKPiAg Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfZmlsZV9wcml2YXRlICpmaWxlX3ByaXY7Cj4gIAkvKiogZmls ZV9wcml2IGxpc3QgZW50cnkgZm9yIHRoaXMgcmVxdWVzdCAqLwo+IC0Jc3RydWN0IGxpc3RfaGVh ZCBjbGllbnRfbGlzdDsKPiArCXN0cnVjdCBsaXN0X2hlYWQgY2xpZW50X2xpbms7Cj4gIAo+ICAJ LyoqCj4gIAkgKiBUaGUgRUxTUCBvbmx5IGFjY2VwdHMgdHdvIGVsZW1lbnRzIGF0IGEgdGltZSwg c28gd2UgcXVldWUKPiBAQCAtMTY3LDggKzE2Nyw2IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBmZW5j ZV9pc19pOTE1KHN0cnVjdCBmZW5jZSAqZmVuY2UpCj4gIHN0cnVjdCBkcm1faTkxNV9nZW1fcmVx dWVzdCAqIF9fbXVzdF9jaGVjawo+ICBpOTE1X2dlbV9yZXF1ZXN0X2FsbG9jKHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgCQkgICAgICAgc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQg KmN0eCk7Cj4gLWludCBpOTE1X2dlbV9yZXF1ZXN0X2FkZF90b19jbGllbnQoc3RydWN0IGRybV9p OTE1X2dlbV9yZXF1ZXN0ICpyZXEsCj4gLQkJCQkgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpOwo+ ICB2b2lkIGk5MTVfZ2VtX3JlcXVlc3RfcmV0aXJlX3VwdG8oc3RydWN0IGRybV9pOTE1X2dlbV9y ZXF1ZXN0ICpyZXEpOwo+ICAKPiAgc3RhdGljIGlubGluZSB1MzIKPiAtLSAKPiAyLjkuMwo+Cj4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1n ZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=