From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] tests/drv_missed_irq_hang: Fix gem_blt path
Date: Thu, 16 Jun 2016 17:37:54 +0300 [thread overview]
Message-ID: <87a8ilw665.fsf@intel.com> (raw)
In-Reply-To: <20160615122853.GQ4184@nuc-i3427.alporthouse.com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> On Wed, Jun 15, 2016 at 02:56:39PM +0300, Marius Vlad wrote:
>> On Mon, Jun 13, 2016 at 04:26:22PM +0300, Mika Kuoppala wrote:
>> > Don't add SOURCE_DIR to the path for gem_blt as if this
>> > script is invocated on some other directory, the path to
>> > gem_blt will be concatenated two times.
>> >
>> > References: https://bugs.freedesktop.org/show_bug.cgi?id=88437
>> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>> > ---
>> > tests/drv_missed_irq_hang | 4 ++--
>> > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/tests/drv_missed_irq_hang b/tests/drv_missed_irq_hang
>> > index e76c7db674ac..96a653846005 100755
>> > --- a/tests/drv_missed_irq_hang
>> > +++ b/tests/drv_missed_irq_hang
>> > @@ -6,12 +6,12 @@
>> > SOURCE_DIR="$( dirname "${BASH_SOURCE[0]}" )"
>> > . $SOURCE_DIR/drm_lib.sh
>> >
>> > -oldpath=`pwd`
>> > +oldpath=$PWD
>> >
>> > cd $i915_dfs_path
>> >
>> > function blt_wait {
>> > - $oldpath/$SOURCE_DIR/../benchmarks/gem_blt -r 1 -b 64 -t 1 -S > /dev/null
>> > + ${oldpath}/../benchmarks/gem_blt -r 1 -b 64 -t 1 -S > /dev/null
>> But $SOURCE_DIR will always be '.'. If installed, benchmarks/ will be
>> underneath tests/ directory. Is that what you're trying to fix?
>>
My stab at https://bugs.freedesktop.org/show_bug.cgi?id=88437
>> Posted a fix for this when running under piglit:
>> https://patchwork.freedesktop.org/patch/87378/
>
If it fixes the bug above, go for it.
> Neither seem like a general solution for finding the testcase, for all of
> the installed, not-installed, mixed-installed combinations.
>
> Even more tricky is that we want tighter control over the batch to avoid
> a fast GPU never enabling irqs and so never noticing the failed delivery
> (either the operation is completed before the wait, or it will complete
> within the spin).
> -Chris
How about we give up and convert that test C to gain control?
-Mika
>
> --
> Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-06-16 14:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 13:26 [PATCH i-g-t] tests/drv_missed_irq_hang: Fix gem_blt path Mika Kuoppala
2016-06-15 11:56 ` Marius Vlad
2016-06-15 12:28 ` Chris Wilson
2016-06-16 14:37 ` Mika Kuoppala [this message]
2016-06-16 21:36 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8ilw665.fsf@intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.