From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgvOW-0003WE-Rf for qemu-devel@nongnu.org; Tue, 29 Sep 2015 09:56:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZgvOS-00015u-Tz for qemu-devel@nongnu.org; Tue, 29 Sep 2015 09:56:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgvOS-00015k-OM for qemu-devel@nongnu.org; Tue, 29 Sep 2015 09:56:32 -0400 From: Markus Armbruster References: <1443497249-15361-1-git-send-email-eblake@redhat.com> <1443497249-15361-13-git-send-email-eblake@redhat.com> Date: Tue, 29 Sep 2015 15:56:30 +0200 In-Reply-To: <1443497249-15361-13-git-send-email-eblake@redhat.com> (Eric Blake's message of "Mon, 28 Sep 2015 21:27:25 -0600") Message-ID: <87a8s5ib1t.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v6 12/16] qapi: Consistent generated code: prefer common labels List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, Michael Roth Eric Blake writes: > We had some pointless differences in the generated code for visit, > command marshalling, and events; unifying them makes it easier for > future patches to consolidate to common helper functions. > > This is patch 3/4, focusing on naming the goto labels 'out' (not > 'clean') and 'out_obj' (not 'out_end'). Additionally, the generator > was inconsistent on whether labels had a leading space; prefer the > emacs style of including the space, so that only function names and > comments occur in column 1 of the generated file [HACKING gives no > preference, and both styles occur elsewhere in qemu.git]. Your Emacs prefers this? Mine doesn't. If I read CC Mode correctly, only style "gnu" does this. I use "stroustrup" for QEMU, because it's very close. It doesn't do this. As far as I can see, the only label we generate indented before this patch is qapi-event.py's clean. When in doubt, avoid the churn: we rename that one anyway, so let's drop the space there, and leave the others alone. > No change in semantics to the generated code. > > Signed-off-by: Eric Blake > > --- > v6: split 9/46 into four patches, update docs where they are affected, > pick consistent spacing of label > > Signed-off-by: Eric Blake