All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Correct drm display mode table about 1856x1392 @75Hz mode
@ 2015-04-02 10:54 liu,lei
  2015-04-02 12:11 ` Jani Nikula
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: liu,lei @ 2015-04-02 10:54 UTC (permalink / raw)
  To: intel-gfx; +Cc: liu,lei, gordon.jin

From: "liu,lei" <lei.a.liu@intel.com>

According DMT spec, vss of this mode should be 1393, vse should
be 1396.

VESA MONITOR TIMING STANDARD:

Timing Name = 1856 x 1392 @ 75Hz
Hor Total Time = 8.889;  (usec) = 320 chars = 2560 Pixels
Hor Sync Start = 6.889;  (usec) = 248 chars = 1984 Pixels
H Back Porch = 1.222;  (usec) = 44 chars = 352 Pixels

Ver Total Time = 13.333;  (msec) = 1500 lines HT – (1.06xHA)
Ver Sync Start = 12.382;  (msec) = 1393 lines
V Back Porch = 0.924;  (msec) = 104 lines
---
 drivers/gpu/drm/drm_edid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 53bc7a6..16991ea 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -409,7 +409,7 @@ static const struct drm_display_mode drm_dmt_modes[] = {
 		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
 	/* 1856x1392@75Hz */
 	{ DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 288000, 1856, 1984,
-		   2208, 2560, 0, 1392, 1395, 1399, 1500, 0,
+		   2208, 2560, 0, 1392, 1393, 1396, 1500, 0,
 		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
 	/* 1856x1392@120Hz RB */
 	{ DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 356500, 1856, 1904,
-- 
1.8.3.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Correct drm display mode table about 1856x1392 @75Hz mode
  2015-04-02 10:54 [PATCH] Correct drm display mode table about 1856x1392 @75Hz mode liu,lei
@ 2015-04-02 12:11 ` Jani Nikula
  2015-04-02 13:37 ` Ville Syrjälä
  2015-04-03  7:30 ` shuang.he
  2 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2015-04-02 12:11 UTC (permalink / raw)
  To: intel-gfx; +Cc: liu,lei, gordon.jin


Please prefix the subject with "drm/edid: " and send the patch to
dri-devel@lists.freedesktop.org.

In general, scripts/get_maintainer.pl will tell you where to send the
patches; intel-gfx is for stuff under drivers/gpu/drm/i915.

Thanks,
Jani.

On Thu, 02 Apr 2015, "liu,lei" <lei.a.liu@intel.com> wrote:
> From: "liu,lei" <lei.a.liu@intel.com>
>
> According DMT spec, vss of this mode should be 1393, vse should
> be 1396.
>
> VESA MONITOR TIMING STANDARD:
>
> Timing Name = 1856 x 1392 @ 75Hz
> Hor Total Time = 8.889;  (usec) = 320 chars = 2560 Pixels
> Hor Sync Start = 6.889;  (usec) = 248 chars = 1984 Pixels
> H Back Porch = 1.222;  (usec) = 44 chars = 352 Pixels
>
> Ver Total Time = 13.333;  (msec) = 1500 lines HT – (1.06xHA)
> Ver Sync Start = 12.382;  (msec) = 1393 lines
> V Back Porch = 0.924;  (msec) = 104 lines
> ---
>  drivers/gpu/drm/drm_edid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 53bc7a6..16991ea 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -409,7 +409,7 @@ static const struct drm_display_mode drm_dmt_modes[] = {
>  		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
>  	/* 1856x1392@75Hz */
>  	{ DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 288000, 1856, 1984,
> -		   2208, 2560, 0, 1392, 1395, 1399, 1500, 0,
> +		   2208, 2560, 0, 1392, 1393, 1396, 1500, 0,
>  		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
>  	/* 1856x1392@120Hz RB */
>  	{ DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 356500, 1856, 1904,
> -- 
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Correct drm display mode table about 1856x1392 @75Hz mode
  2015-04-02 10:54 [PATCH] Correct drm display mode table about 1856x1392 @75Hz mode liu,lei
  2015-04-02 12:11 ` Jani Nikula
@ 2015-04-02 13:37 ` Ville Syrjälä
  2015-04-03  7:30 ` shuang.he
  2 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2015-04-02 13:37 UTC (permalink / raw)
  To: liu,lei; +Cc: intel-gfx, gordon.jin

On Thu, Apr 02, 2015 at 06:54:34PM +0800, liu,lei wrote:
> From: "liu,lei" <lei.a.liu@intel.com>
> 
> According DMT spec, vss of this mode should be 1393, vse should
> be 1396.
> 
> VESA MONITOR TIMING STANDARD:
> 
> Timing Name = 1856 x 1392 @ 75Hz
> Hor Total Time = 8.889;  (usec) = 320 chars = 2560 Pixels
> Hor Sync Start = 6.889;  (usec) = 248 chars = 1984 Pixels
> H Back Porch = 1.222;  (usec) = 44 chars = 352 Pixels
> 
> Ver Total Time = 13.333;  (msec) = 1500 lines HT – (1.06xHA)
> Ver Sync Start = 12.382;  (msec) = 1393 lines
> V Back Porch = 0.924;  (msec) = 104 lines
> ---
>  drivers/gpu/drm/drm_edid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 53bc7a6..16991ea 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -409,7 +409,7 @@ static const struct drm_display_mode drm_dmt_modes[] = {
>  		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
>  	/* 1856x1392@75Hz */
>  	{ DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 288000, 1856, 1984,
> -		   2208, 2560, 0, 1392, 1395, 1399, 1500, 0,
> +		   2208, 2560, 0, 1392, 1393, 1396, 1500, 0,

That is indeed what the spec says. However to review this I wrote a
quick awk script to parse the spec, and that shows a few more
differences. I'll toss out a patch with the results of my script...

>  		   DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_PVSYNC) },
>  	/* 1856x1392@120Hz RB */
>  	{ DRM_MODE("1856x1392", DRM_MODE_TYPE_DRIVER, 356500, 1856, 1904,
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Correct drm display mode table about 1856x1392 @75Hz mode
  2015-04-02 10:54 [PATCH] Correct drm display mode table about 1856x1392 @75Hz mode liu,lei
  2015-04-02 12:11 ` Jani Nikula
  2015-04-02 13:37 ` Ville Syrjälä
@ 2015-04-03  7:30 ` shuang.he
  2 siblings, 0 replies; 4+ messages in thread
From: shuang.he @ 2015-04-03  7:30 UTC (permalink / raw)
  To: shuang.he, ethan.gao, intel-gfx, lei.a.liu

Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 6127
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
PNV                 -1              272/272              271/272
ILK                                  302/302              302/302
SNB                                  303/303              303/303
IVB                                  338/338              338/338
BYT                 -1              287/287              286/287
HSW                                  361/361              361/361
BDW                                  308/308              308/308
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
 PNV  igt@gen3_render_tiledx_blits      FAIL(6)PASS(6)      FAIL(1)PASS(1)
*BYT  igt@gem_exec_bad_domains@conflicting-write-domain      PASS(17)      FAIL(1)PASS(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-04-03  7:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-02 10:54 [PATCH] Correct drm display mode table about 1856x1392 @75Hz mode liu,lei
2015-04-02 12:11 ` Jani Nikula
2015-04-02 13:37 ` Ville Syrjälä
2015-04-03  7:30 ` shuang.he

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.