From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: make system freeze support depend on CONFIG_ACPI_SLEEP Date: Tue, 24 Jun 2014 16:54:13 +0300 Message-ID: <87a9928lbu.fsf@intel.com> References: <1403527562-28919-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 09FBA6E524 for ; Tue, 24 Jun 2014 06:54:21 -0700 (PDT) In-Reply-To: <1403527562-28919-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 23 Jun 2014, Imre Deak wrote: > To achieve further power savings during system freeze (aka connected > standby, or s0ix) we have to send a PCI_D1 opregion notification. As > the information about the state we're entering (system freeze, > suspend to ram or suspend to disk) is only available through the ACPI > subsystem, make this support depend on the relevant kconfig option. > Things will still work if this option isn't set, albeit with less than > optimial power saving. > > This also fixes a compile breakage when the option is not set introduced > in > > commit e5747e3adcd67ae27105003ec99fb58cba180105 > Author: Jesse Barnes > Date: Thu Jun 12 08:35:47 2014 -0700 > > drm/i915: send proper opregion notifications on suspend/resume > > Reported-by: Randy Dunlap > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/i915_drv.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 7ae4e2a..43dc8f7 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -544,10 +544,11 @@ static int i915_drm_freeze(struct drm_device *dev) > > i915_save_state(dev); > > - if (acpi_target_system_state() >= ACPI_STATE_S3) > - opregion_target_state = PCI_D3cold; > - else > + opregion_target_state = PCI_D3cold; > +#if IS_ENABLED(CONFIG_ACPI_SLEEP) Maybe this should just check for CONFIG_ACPI? BR, Jani. > + if (acpi_target_system_state() < ACPI_STATE_S3) > opregion_target_state = PCI_D1; > +#endif > intel_opregion_notify_adapter(dev, opregion_target_state); > > intel_uncore_forcewake_reset(dev, false); > -- > 1.8.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center