Re: [PATCH 2/8] shdma: fdt: allocate and use local hwid bitmap for shdma mux

[Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>]

Hi Ben

> Move the shdma-of.c code to allocating and using a slave bitmap for
> tracking allocation of the slave channels used by the mid-rid stored
> in the phandle for the mux.
> 
> This means that we can have multiple shdma muxes in the system without
> any issue of slave-ids clashing and all the child dma units will be
> able to properly protect against the re-use of a mid/rid pair.
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
(snip)
> +void shdma_of_setup(struct device *dev, struct shdma_dev *shdev)
> +{
> +	struct shdma_of_state *ofs = dev_get_platdata(dev->parent);
> +
> +	shdev->slave_used = ofs->slave_used;
> +}
> +
>  static int shdma_of_probe(struct platform_device *pdev)
>  {
>  	const struct of_dev_auxdata *lookup = dev_get_platdata(&pdev->dev);
> +	struct shdma_of_state *ofs;
>  	int ret;
>  
> +	ofs = devm_kzalloc(&pdev->dev, sizeof(*ofs), GFP_KERNEL);
> +	if (!ofs)
> +		return -ENOMEM;
> +
>  	ret = of_dma_controller_register(pdev->dev.of_node,
>  					 shdma_of_xlate, pdev);
>  	if (ret < 0)
> diff --git a/include/linux/shdma-base.h b/include/linux/shdma-base.h

This ofs is created by devm_kzalloc(), but not used ??
It is missing to call dev_set_platdata() ?