All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] fbdev: sh_mobile_lcdc: Fix vertical panning step
Date: Mon, 30 Jul 2012 01:25:59 +0000	[thread overview]
Message-ID: <87a9yi6nve.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <1343306215-20868-1-git-send-email-laurent.pinchart@ideasonboard.com>


Hi Laurent

> diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c
> index 8cb653b..699487c 100644
> --- a/drivers/video/sh_mobile_lcdcfb.c
> +++ b/drivers/video/sh_mobile_lcdcfb.c
> @@ -1716,11 +1716,11 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl)
>  		info->fix.visual = FB_VISUAL_TRUECOLOR;
>  
>  	switch (ovl->format->fourcc) {
> -	case V4L2_PIX_FMT_NV16:
> -	case V4L2_PIX_FMT_NV61:
> -		info->fix.ypanstep = 2;
>  	case V4L2_PIX_FMT_NV12:
>  	case V4L2_PIX_FMT_NV21:
> +		info->fix.ypanstep = 2;
> +	case V4L2_PIX_FMT_NV16:
> +	case V4L2_PIX_FMT_NV61:
>  		info->fix.xpanstep = 2;
>  	}
>  
> @@ -2215,11 +2215,11 @@ sh_mobile_lcdc_channel_fb_init(struct sh_mobile_lcdc_chan *ch,
>  		info->fix.visual = FB_VISUAL_TRUECOLOR;
>  
>  	switch (ch->format->fourcc) {
> -	case V4L2_PIX_FMT_NV16:
> -	case V4L2_PIX_FMT_NV61:
> -		info->fix.ypanstep = 2;
>  	case V4L2_PIX_FMT_NV12:
>  	case V4L2_PIX_FMT_NV21:
> +		info->fix.ypanstep = 2;
> +	case V4L2_PIX_FMT_NV16:
> +	case V4L2_PIX_FMT_NV61:
>  		info->fix.xpanstep = 2;
>  	}

If possible, could you please add comment /* fall through */ ?
current code is a little bit confusing

Best regards
---
Kuninori Morimoto

  reply	other threads:[~2012-07-30  1:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26 12:36 [PATCH] fbdev: sh_mobile_lcdc: Fix vertical panning step Laurent Pinchart
2012-07-30  1:25 ` Kuninori Morimoto [this message]
2012-08-06 15:26 ` Laurent Pinchart
2012-08-07  1:27 ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9yi6nve.wl%kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.