From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161500Ab2GLRsH (ORCPT ); Thu, 12 Jul 2012 13:48:07 -0400 Received: from na3sys009aog128.obsmtp.com ([74.125.149.141]:51109 "EHLO na3sys009aog128.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934162Ab2GLRsD (ORCPT ); Thu, 12 Jul 2012 13:48:03 -0400 From: Kevin Hilman To: Linus Walleij Cc: Tarun Kanti DebBarma , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rajendra Nayak , Santosh Shilimkar , "Cousson\, Benoit" , Paul Walmsley Subject: Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver Organization: Texas Instruments, Inc. References: <1341997995-14020-1-git-send-email-tarun.kanti@ti.com> <1341997995-14020-3-git-send-email-tarun.kanti@ti.com> <87394xhocn.fsf@ti.com> Date: Thu, 12 Jul 2012 10:48:01 -0700 In-Reply-To: (Linus Walleij's message of "Thu, 12 Jul 2012 13:03:00 +0200") Message-ID: <87a9z4g9bi.fsf@ti.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, Linus Walleij writes: > On Thu, Jul 12, 2012 at 1:25 AM, Kevin Hilman wrote: > >> There is quite a bit of other things to do in remove to properly cleanup >> what is done in probe. > > OK I'm dropping this patch for now... > Thanks. For future reference... as one of the OMAP maintainers, I request that you not pull/merge OMAP GPIO patches unless they've had a bit of review and exposure. Unfortunately, we have a history with this driver where regressions have been introduced and the maintainers end up having to find and fix them. In the case of OMAP GPIO, unless it's an obvious fix, I would recommend you wait at least until you see some acks/tested tags from any of - Santosh Shilimkar - Rajendra Nayak - Benoit Cousson or Tony, Paul or myself. For major series, I have been collecting/queueing them for Grant after ensuring they have been well reviewed and well tested (although I am eagerly hoping to hand off this role to someone else.) Thanks, Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver Date: Thu, 12 Jul 2012 10:48:01 -0700 Message-ID: <87a9z4g9bi.fsf@ti.com> References: <1341997995-14020-1-git-send-email-tarun.kanti@ti.com> <1341997995-14020-3-git-send-email-tarun.kanti@ti.com> <87394xhocn.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog130.obsmtp.com ([74.125.149.143]:37692 "EHLO na3sys009aog130.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932762Ab2GLRsB (ORCPT ); Thu, 12 Jul 2012 13:48:01 -0400 Received: by ghy10 with SMTP id 10so4935032ghy.16 for ; Thu, 12 Jul 2012 10:48:00 -0700 (PDT) In-Reply-To: (Linus Walleij's message of "Thu, 12 Jul 2012 13:03:00 +0200") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Linus Walleij Cc: Tarun Kanti DebBarma , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rajendra Nayak , Santosh Shilimkar , "Cousson, Benoit" , Paul Walmsley Hi Linus, Linus Walleij writes: > On Thu, Jul 12, 2012 at 1:25 AM, Kevin Hilman wrote: > >> There is quite a bit of other things to do in remove to properly cleanup >> what is done in probe. > > OK I'm dropping this patch for now... > Thanks. For future reference... as one of the OMAP maintainers, I request that you not pull/merge OMAP GPIO patches unless they've had a bit of review and exposure. Unfortunately, we have a history with this driver where regressions have been introduced and the maintainers end up having to find and fix them. In the case of OMAP GPIO, unless it's an obvious fix, I would recommend you wait at least until you see some acks/tested tags from any of - Santosh Shilimkar - Rajendra Nayak - Benoit Cousson or Tony, Paul or myself. For major series, I have been collecting/queueing them for Grant after ensuring they have been well reviewed and well tested (although I am eagerly hoping to hand off this role to someone else.) Thanks, Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Thu, 12 Jul 2012 10:48:01 -0700 Subject: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver In-Reply-To: (Linus Walleij's message of "Thu, 12 Jul 2012 13:03:00 +0200") References: <1341997995-14020-1-git-send-email-tarun.kanti@ti.com> <1341997995-14020-3-git-send-email-tarun.kanti@ti.com> <87394xhocn.fsf@ti.com> Message-ID: <87a9z4g9bi.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Linus, Linus Walleij writes: > On Thu, Jul 12, 2012 at 1:25 AM, Kevin Hilman wrote: > >> There is quite a bit of other things to do in remove to properly cleanup >> what is done in probe. > > OK I'm dropping this patch for now... > Thanks. For future reference... as one of the OMAP maintainers, I request that you not pull/merge OMAP GPIO patches unless they've had a bit of review and exposure. Unfortunately, we have a history with this driver where regressions have been introduced and the maintainers end up having to find and fix them. In the case of OMAP GPIO, unless it's an obvious fix, I would recommend you wait at least until you see some acks/tested tags from any of - Santosh Shilimkar - Rajendra Nayak - Benoit Cousson or Tony, Paul or myself. For major series, I have been collecting/queueing them for Grant after ensuring they have been well reviewed and well tested (although I am eagerly hoping to hand off this role to someone else.) Thanks, Kevin