From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH v1 1/1] mmc: bus: print bus speed mode of UHS-I card Date: Sat, 31 Mar 2012 23:55:03 -0400 Message-ID: <87aa2wm7hk.fsf@laptop.org> References: <1332482196-22572-1-git-send-email-subhashj@codeaurora.org> <4F700BE5.2050101@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from void.printf.net ([89.145.121.20]:56858 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777Ab2DADy6 (ORCPT ); Sat, 31 Mar 2012 23:54:58 -0400 In-Reply-To: <4F700BE5.2050101@codeaurora.org> (Stephen Boyd's message of "Sun, 25 Mar 2012 23:25:41 -0700") Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Subhash Jadavani , linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, arindam.nath@amd.com Hi Subhash, On Mon, Mar 26 2012, Stephen Boyd wrote: > On 3/22/2012 10:56 PM, Subhash Jadavani wrote: >> @@ -296,6 +297,28 @@ int mmc_add_card(struct mmc_card *card) >> break; >> } >> >> + if (mmc_sd_card_uhs(card)) { >> + switch (card->sd_bus_speed) { >> + case UHS_SDR104_BUS_SPEED: >> + uhs_bus_speed_mode = "SDR104 "; >> + break; >> + case UHS_SDR50_BUS_SPEED: >> + uhs_bus_speed_mode = "SDR50 "; >> + break; >> + case UHS_DDR50_BUS_SPEED: >> + uhs_bus_speed_mode = "DDR50 "; >> + break; >> + case UHS_SDR25_BUS_SPEED: >> + uhs_bus_speed_mode = "SDR25 "; >> + break; >> + case UHS_SDR12_BUS_SPEED: >> + uhs_bus_speed_mode = "SDR12 "; >> + break; >> + default: >> + uhs_bus_speed_mode = ""; >> + break; >> + } >> > > This could be better code with an array: > > static char *speeds[] = { > [UHS_SDR104_BUS_SPEED] = "SDR104", > [UHS_SDR50_BUS_SPEED] = "SDR50", > [UHS_SDR50_BUS_SPEED] = "DDR50", > ... > }; I'm happy to take the patch in general (I agree that having bus speed in dmesg is very useful for analyzing bug reports), but let's use Stephen's suggestion above. Please resend. Thanks! - Chris. -- Chris Ball One Laptop Per Child