All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steinar Bang <sb@dod.no>
To: git@vger.kernel.org
Subject: Re: Merging back from master but keeping a subtree
Date: Wed, 16 Nov 2011 14:39:40 +0100	[thread overview]
Message-ID: <87aa7wrxsz.fsf@dod.no> (raw)
In-Reply-To: 20110918033719.GB17977@sigill.intra.peff.net

>>>>> Jeff King <peff@peff.net>:

> Git should generally do that automatically, unless both sides are
> changing mydirectory. In which case it will produce conflicts.

I thought so too, but the end result didn't build, and I was unable to
figure out why.

> Are you sure you really want to just throw out what the other side did
> in mydirectory?

Yes, that's the only thing I'm sure about.  All changes to mydirectory
should come from my branch.  If there are changes necessary to make
things build, they are better done by me.

> If git was able to auto-merge some files, then they will not be marked
> as conflicts in the index. And "git checkout --ours" is about looking in
> the index for conflicted entries, and then selecting one side.

> I think what you want instead is to do is (assuming you really want to
> throw out their side):

Thanks for the suggestion.  I tried following this approach, but...

>   1. Start a merge between them and us:

>        git merge --no-commit remoterepo/master

>   2. Throw out whatever the merge came up with and make it look like
>      their tree:

...I never quite could figure out if I did the right thing here.
Ie. when throwing out what the commit came up with.

>        git checkout remoterepo/master -- top

>   3. Now overwrite their version of mydirectory with what was in your
>      branch:

>        git checkout HEAD -- top/middle/mydirectory

>   4. Commit the resulting tree:

>        git commit

The problem was that the end result didn't build, wit pretty much the
same obscure failures that the regular merge had.

But I eventually tried something that worked:
 1. First create a local branch off master
 2. Merge in mybranch with "-s ours --no-commit"
 3. Checkout mydirectory from mybranch
 4. Commit
 5. Switch to mybranch
 6. Merge in the new local branch, which resulted in a conflict-free
    merge that has my changes in mydirectory and the rest of the world
    in the rest of the working directory, and the history of mydirectory
    looks ok

The end result built and worked.

If git had had a "-s theirs" strategy, I wouldn't have needed the
temporary branch made off master.  That need for that branch is probably
the most cryptic thing for people following my instructions for future
merges.

To sum up the commands:
 git checkout master
 git checkout -b master_nicely_merged_with_mybranch
 git merge -s ours --no-commit origin/mybranch
 git checkout origin/mybranch top/middle/mydirectory
 git commit
 git checkout mybranch
 git merge master_nicely_merged_with_mybranch

Thanks!


- Steinar

      reply	other threads:[~2011-11-16 13:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-17  7:49 Merging back from master but keeping a subtree Steinar Bang
2011-09-18  3:37 ` Jeff King
2011-11-16 13:39   ` Steinar Bang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87aa7wrxsz.fsf@dod.no \
    --to=sb@dod.no \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.