From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF241C433E1 for ; Tue, 23 Mar 2021 13:05:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0559619BD for ; Tue, 23 Mar 2021 13:05:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231405AbhCWNF2 (ORCPT ); Tue, 23 Mar 2021 09:05:28 -0400 Received: from foss.arm.com ([217.140.110.172]:46078 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231211AbhCWNFI (ORCPT ); Tue, 23 Mar 2021 09:05:08 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ABBD6106F; Tue, 23 Mar 2021 06:05:07 -0700 (PDT) Received: from [10.57.50.37] (unknown [10.57.50.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 721A03F719; Tue, 23 Mar 2021 06:05:06 -0700 (PDT) Subject: Re: [PATCH 3/3] iova: Correct comment for free_cpu_cached_iovas() To: John Garry , dwmw2@infradead.org, baolu.lu@linux.intel.com, joro@8bytes.org, will@kernel.org Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com References: <1614600741-15696-1-git-send-email-john.garry@huawei.com> <1614600741-15696-4-git-send-email-john.garry@huawei.com> From: Robin Murphy Message-ID: <87b4af01-2352-e963-824f-1cea1a6ee718@arm.com> Date: Tue, 23 Mar 2021 13:05:01 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1614600741-15696-4-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-03-01 12:12, John Garry wrote: > Function free_cpu_cached_iovas() is not only called when a CPU is > hotplugged, so remove that part of the code comment. FWIW I read it as clarifying why this is broken out into a separate function vs. a monolithic "free all cached IOVAs" routine that handles both the per-cpu and global caches - it never said "*only* used..." As such I'd hesitate to call it incorrect, but it's certainly arguable whether it needs to be stated or not, especially once the hotplug callsite is now obvious in the same file - on which note the function itself also shouldn't need to be public any more, no? Robin. > Signed-off-by: John Garry > --- > drivers/iommu/iova.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c > index c78312560425..465b3b0eeeb0 100644 > --- a/drivers/iommu/iova.c > +++ b/drivers/iommu/iova.c > @@ -996,7 +996,7 @@ static void free_iova_rcaches(struct iova_domain *iovad) > } > > /* > - * free all the IOVA ranges cached by a cpu (used when cpu is unplugged) > + * free all the IOVA ranges cached by a cpu > */ > void free_cpu_cached_iovas(unsigned int cpu, struct iova_domain *iovad) > { > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_RED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 058C9C433DB for ; Tue, 23 Mar 2021 13:05:13 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DA80619B6 for ; Tue, 23 Mar 2021 13:05:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DA80619B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id DBA9E6058B; Tue, 23 Mar 2021 13:05:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JlMTMZ6-tpyJ; Tue, 23 Mar 2021 13:05:11 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTP id C7D73605D8; Tue, 23 Mar 2021 13:05:10 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B0C20C000B; Tue, 23 Mar 2021 13:05:10 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 785E8C0001 for ; Tue, 23 Mar 2021 13:05:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5121A605D8 for ; Tue, 23 Mar 2021 13:05:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fZKvwO5-KCEW for ; Tue, 23 Mar 2021 13:05:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp3.osuosl.org (Postfix) with ESMTP id 64D4F6058B for ; Tue, 23 Mar 2021 13:05:08 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ABBD6106F; Tue, 23 Mar 2021 06:05:07 -0700 (PDT) Received: from [10.57.50.37] (unknown [10.57.50.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 721A03F719; Tue, 23 Mar 2021 06:05:06 -0700 (PDT) Subject: Re: [PATCH 3/3] iova: Correct comment for free_cpu_cached_iovas() To: John Garry , dwmw2@infradead.org, baolu.lu@linux.intel.com, joro@8bytes.org, will@kernel.org References: <1614600741-15696-1-git-send-email-john.garry@huawei.com> <1614600741-15696-4-git-send-email-john.garry@huawei.com> From: Robin Murphy Message-ID: <87b4af01-2352-e963-824f-1cea1a6ee718@arm.com> Date: Tue, 23 Mar 2021 13:05:01 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1614600741-15696-4-git-send-email-john.garry@huawei.com> Content-Language: en-GB Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 2021-03-01 12:12, John Garry wrote: > Function free_cpu_cached_iovas() is not only called when a CPU is > hotplugged, so remove that part of the code comment. FWIW I read it as clarifying why this is broken out into a separate function vs. a monolithic "free all cached IOVAs" routine that handles both the per-cpu and global caches - it never said "*only* used..." As such I'd hesitate to call it incorrect, but it's certainly arguable whether it needs to be stated or not, especially once the hotplug callsite is now obvious in the same file - on which note the function itself also shouldn't need to be public any more, no? Robin. > Signed-off-by: John Garry > --- > drivers/iommu/iova.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c > index c78312560425..465b3b0eeeb0 100644 > --- a/drivers/iommu/iova.c > +++ b/drivers/iommu/iova.c > @@ -996,7 +996,7 @@ static void free_iova_rcaches(struct iova_domain *iovad) > } > > /* > - * free all the IOVA ranges cached by a cpu (used when cpu is unplugged) > + * free all the IOVA ranges cached by a cpu > */ > void free_cpu_cached_iovas(unsigned int cpu, struct iova_domain *iovad) > { > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu