All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.debian@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
Date: Tue, 11 Jun 2019 12:40:02 +0200	[thread overview]
Message-ID: <87bb71c4-5e37-1bb8-7c61-8b775e57ca73@gmx.de> (raw)
In-Reply-To: <E1hIFmC-00080g-3M@mail.theobroma-systems.com>

On 4/21/19 6:57 PM, Philipp Tomsich wrote:
>> The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit
>> is exceeded.
>>
>> CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's
>> disable it.
>>
>> Suggested-by: David Wu <david.wu@rock-chips.com>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> Reviewed-by: David Wu <david.wu@rock-chips.com>
>> ---
>> This solves only one of the problems with the boards in v2019.04.
>> The next problem is that reading the environment from MMC fails.
>>
>> The patch
>> [PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
>> https://lists.denx.de/pipermail/u-boot/2019-February/358883.html
>> makes the problem visibe.
>> ---
>>  configs/tinker-rk3288_defconfig | 1 -
>>  1 file changed, 1 deletion(-)
>>
>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

Hello Tom,

could you, please, merge this patch that has been lingering since
February to fix the build issue for the TinkerBoard:

https://lists.denx.de/pipermail/u-boot/2019-February/360367.html
https://patchwork.ozlabs.org/patch/1049112/

You will have to rebase the patch:

 CONFIG_SPL_TEXT_BASE=0xff704000 <<<< change this line
 CONFIG_SPL_STACK_R=y
 CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000
-CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_I2C=y

Best regards

Heinrich

  reply	other threads:[~2019-06-11 10:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-27 19:05 [U-Boot] [PATCH 1/1] configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT Heinrich Schuchardt
2019-04-01  5:51 ` Heinrich Schuchardt
2019-04-01 10:20 ` David Wu
2019-04-21 16:57 ` [U-Boot] [U-Boot, " Philipp Tomsich
2019-06-11 10:40   ` Heinrich Schuchardt [this message]
2019-06-11 12:13 ` [U-Boot] [PATCH " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bb71c4-5e37-1bb8-7c61-8b775e57ca73@gmx.de \
    --to=xypron.debian@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.