All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org,  qemu-arm@nongnu.org,
	 qemu-block@nongnu.org, Stefan Weil <sw@weilnetz.de>,
	 "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH-for-8.1 5/5] bulk: Replace __attribute__((noreturn)) -> G_NORETURN
Date: Tue, 21 Mar 2023 13:56:18 +0100	[thread overview]
Message-ID: <87bkkmjma5.fsf@secure.mitica> (raw)
In-Reply-To: <20230320134219.22489-6-philmd@linaro.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Mon, 20 Mar 2023 14:42:19 +0100")

Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> Under MSYS2, G_NORETURN is expanded to '[[noreturn]]'.
> Simpler to use the same definition everywhere, unifying
> the code style.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Juan Quintela <quintela@redhat.com>



      reply	other threads:[~2023-03-21 12:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 13:42 [PATCH-for-8.1 0/5] bulk: Do not declare function prototypes using 'extern' keyword Philippe Mathieu-Daudé
2023-03-20 13:42 ` [PATCH-for-8.1 1/5] qemu/osdep.h: Do not declare function prototypes using extern keyword Philippe Mathieu-Daudé
2023-03-20 13:42 ` [PATCH-for-8.1 2/5] block/dmg: Remove duplicated prototype declarations Philippe Mathieu-Daudé
2023-03-20 13:50   ` Daniel P. Berrangé
2023-03-20 13:42 ` [PATCH-for-8.1 3/5] qemu/uri: Use QueryParams type definition Philippe Mathieu-Daudé
2023-03-20 13:42 ` [PATCH-for-8.1 4/5] bulk: Do not declare function prototypes using extern keyword Philippe Mathieu-Daudé
2023-03-20 13:48   ` Daniel P. Berrangé
2023-03-20 14:23     ` Philippe Mathieu-Daudé
2023-03-20 13:42 ` [PATCH-for-8.1 5/5] bulk: Replace __attribute__((noreturn)) -> G_NORETURN Philippe Mathieu-Daudé
2023-03-21 12:56   ` Juan Quintela [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkkmjma5.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.