From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4F3BECAAA1 for ; Tue, 13 Sep 2022 03:08:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BCC3210E1A9; Tue, 13 Sep 2022 03:08:38 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD2B010E1A9 for ; Tue, 13 Sep 2022 03:08:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663038514; x=1694574514; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=ViSvPm4xSyzQWdPGI+a5PRHHqngd0HxM9m0IJUQp8/k=; b=BSLxp3cguL/7AWIf4JR3lc4lc0MW1RPy6TnohgJjjKtqHvn7SQiyNemq 1RkIitqWwRyqevRy3AZsaktib6Dbn2G9XDOfSwXUlzxiQnGnHBiLbntO/ 4E6fdiNDS2payjRhRv3zbzVjQyZ0GIS62NAQ+fSg7Yynavt3MgE8v/wMJ pW3QG13iTVjyozwS/NrNoFAhBvOMZWLVbB0Fe1ErJ1+H2Fo5wx7pigvQ3 /3e5peZr98cH6uWC9JveGHGjXo0NHdpd+my2FYB/Xhaiqqa27x7HDvP7t UNOF/Fb6cvpJUKWqac04RnnVMTOG5NFTPLIRXnvz8LriQujpmWV+uH/GP g==; X-IronPort-AV: E=McAfee;i="6500,9779,10468"; a="285044044" X-IronPort-AV: E=Sophos;i="5.93,311,1654585200"; d="scan'208";a="285044044" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 20:08:34 -0700 X-IronPort-AV: E=Sophos;i="5.93,311,1654585200"; d="scan'208";a="567416548" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.54.92]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2022 20:08:33 -0700 Date: Mon, 12 Sep 2022 20:08:33 -0700 Message-ID: <87bkrk55u6.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa In-Reply-To: <87mtb85cvb.wl-ashutosh.dixit@intel.com> References: <20220823204155.8178-1-umesh.nerlige.ramappa@intel.com> <20220823204155.8178-2-umesh.nerlige.ramappa@intel.com> <87mtb85cvb.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 01/19] drm/i915/perf: Fix OA filtering logic for GuC mode X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 09 Sep 2022 16:47:36 -0700, Dixit, Ashutosh wrote: > > On Tue, 23 Aug 2022 13:41:37 -0700, Umesh Nerlige Ramappa wrote: > > > > Hi Umesh, > > > With GuC mode of submission, GuC is in control of defining the context id field > > that is part of the OA reports. To filter reports, UMD and KMD must know what sw > > context id was chosen by GuC. There is not interface between KMD and GuC to > > determine this, so read the upper-dword of EXECLIST_STATUS to filter/squash OA > > reports for the specific context. > > Do you think it is worth defining an interface for GuC to return the sw > ctx_id it will be using for a ctx, say at ctx registration time? Umesh, I came across these in GuC documentation: guc_pcv1_context_parameters_set_h2g_data_t::context_id guc_pcv2_context_parameters_set_h2g_data_t::context_id Also in the code we have in prepare_context_registration_info_v70 'ctx_id = ce->guc_id.id' which seems to be assigned in new_guc_id. So wondering if this is what we need and we already have it? Thanks. -- Ashutosh