From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D4F1C43334 for ; Fri, 3 Jun 2022 13:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234405AbiFCNmY (ORCPT ); Fri, 3 Jun 2022 09:42:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244728AbiFCNmX (ORCPT ); Fri, 3 Jun 2022 09:42:23 -0400 Received: from ms.lwn.net (ms.lwn.net [IPv6:2600:3c01:e000:3a1::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54081286F5 for ; Fri, 3 Jun 2022 06:42:22 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:281:8300:73::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id DAFBC37C; Fri, 3 Jun 2022 13:42:20 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net DAFBC37C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1654263741; bh=CDEFvP1Jem9noEONiIVLPpUiWeuxuA4FOUJvVBoNyRM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BmHQIy6xlyruDDB97VmmT+z2kXomItXBu+a3hzmfZLYQ03V2gblDOsEcjydBwodUR vs2TnoZKGKYizErBui6DzOWmpEJ090dq0OkPrlUNOFMUzm+UdfWlGOrM6o4DPhPOZg n7fxQ2+SYW97e6ri4SmiipMxlczarYyDnBrE4L6Tq59ojemmY/ccttKkGySqv4OIi8 UXK0VAdEdWS9U9XjsXW27k50b1JOVcw76TEJ9aI54lw65MeiS9NF1ipFUDnG9DylzA ZjEANsD5/j+Tv+m/POkLsfi2ecVwe1+jrIyRjOqo4VZvsCt1Sv2fCVwP4Db9HqehcE 7WH1accqk290w== From: Jonathan Corbet To: Bagas Sanjaya , linux-doc@vger.kernel.org Cc: Bagas Sanjaya , Pavel Machek , Bjorn Andersson , Marijn Suijten , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: Add leds-qcom-lpg entry to documentation table of contents In-Reply-To: <20220603025735.17953-1-bagasdotme@gmail.com> References: <20220603025735.17953-1-bagasdotme@gmail.com> Date: Fri, 03 Jun 2022 07:42:33 -0600 Message-ID: <87bkv9x3qu.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Bagas Sanjaya writes: > After merging linux-leds tree to the mainline [1], htmldocs build produces > a new warning: > > checking consistency... /home/bagas/repo/linux-stable/Documentation/leds/leds-qcom-lpg.rst: WARNING: document isn't included in any toctree > > The warning above is because leds-qcom-lpg.rst is missing in the table of > contents. > > Add the missing entry. The fix is good but ... > [1]: https://lore.kernel.org/all/20220531200619.GA8906@duo.ucw.cz/ > > Fixes: e98a860f65428a ("leds: qcom-lpg: Require pattern to follow documentation") ...I'm confused as to why you used that commit for a Fixes: tag. It touched the file in question but didn't add it in the first place; I think 24e2d05d1b68 is the droid you're looking for. jon