All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: igt-dev@lists.freedesktop.org, badal.nilawar@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t 2/3] test: i915_pm_rpm: conditional initialization of igt_display_t
Date: Thu, 21 Apr 2022 16:29:32 -0700	[thread overview]
Message-ID: <87bkwudnhf.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220421170245.11898-3-anshuman.gupta@intel.com>

On Thu, 21 Apr 2022 10:02:44 -0700, Anshuman Gupta wrote:
>
> Initialize igt_display_t display only in case of there are
> valid drm kms resources.
>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>  tests/i915/i915_pm_rpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> index 2cc89eef2..7a0176b2f 100644
> --- a/tests/i915/i915_pm_rpm.c
> +++ b/tests/i915/i915_pm_rpm.c
> @@ -406,9 +406,9 @@ static void init_mode_set_data(struct mode_set_data *data)
>		}
>
>		kmstest_set_vt_graphics_mode();
> +		igt_display_require(&data->display, drm_fd);
>	}
>
> -	igt_display_require(&data->display, drm_fd);

Is this needed? Isn't display_disabled set to false in setup_environment()
for headless? Or is this the right thing to do? Maybe somebody from display
can review? Thanks.

  reply	other threads:[~2022-04-21 23:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21 17:02 [igt-dev] [PATCH i-g-t 0/3] RPM Test on HEADLESS Anshuman Gupta
2022-04-21 17:02 ` [igt-dev] [PATCH i-g-t 1/3] test: i915_pm_rpm: init devid in setup_envirnoment Anshuman Gupta
2022-04-21 23:26   ` Dixit, Ashutosh
2022-04-21 17:02 ` [igt-dev] [PATCH i-g-t 2/3] test: i915_pm_rpm: conditional initialization of igt_display_t Anshuman Gupta
2022-04-21 23:29   ` Dixit, Ashutosh [this message]
2022-04-22  4:30     ` Gupta, Anshuman
2022-05-03 21:17     ` Dixit, Ashutosh
2022-04-21 17:02 ` [igt-dev] [PATCH i-g-t 3/3] i915_pm_rpm: rpm resume by user forcewake Anshuman Gupta
2022-05-04  1:16   ` Dixit, Ashutosh
2022-05-04  2:51     ` Dixit, Ashutosh
2022-05-04  4:32       ` Dixit, Ashutosh
2022-05-11  8:03     ` Gupta, Anshuman
2022-04-21 18:00 ` [igt-dev] ✗ GitLab.Pipeline: warning for RPM Test on HEADLESS Patchwork
2022-04-21 18:25 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-04-21 22:52 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkwudnhf.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.