Re: [PATCH] of/irq: Add a quirk for controllers with their own definition of interrupt-map

From: Marc Zyngier <maz@kernel.org>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"kernel-team@android.com" <kernel-team@android.com>,
	John Crispin <john@phrozen.org>, Biwen Li <biwen.li@nxp.com>,
	Chris Brandt <Chris.Brandt@renesas.com>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] of/irq: Add a quirk for controllers with their own definition of interrupt-map
Date: Tue, 30 Nov 2021 18:36:59 +0000	[thread overview]
Message-ID: <87bl21mqwk.wl-maz@kernel.org> (raw)
In-Reply-To: <CA+V-a8sVS_1hUWJ3uM+VffGyMtdnctBOJTyHTQAoJZGOh0a1Tw@mail.gmail.com>

On Tue, 30 Nov 2021 12:52:21 +0000,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com> wrote:
> 
> On Mon, Nov 29, 2021 at 6:33 PM Rob Herring <robh@kernel.org> wrote:
> >
> > interrupts would work just fine here:
> >
> > interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
> >   <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
> >   <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
> >   <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
> >   <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
> >   <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>,
> >   <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>,
> >   <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
> >
> > We don't need a different solution for N:1 interrupts from N:M. Sure,
> > that could become unweldy if there are a lot of interrupts (just like
> > interrupt-map), but is that an immediate problem?
> >
> It's just that with this approach the driver will have to index the
> interrupts instead of reading from DT.
> 
> Marc - is it OK with the above approach?

Anything that uses standard properties in a standard way works for me.

	M.

-- 
Without deviation from the norm, progress is not possible.