From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 236AEC433EF for ; Thu, 21 Oct 2021 17:05:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A60D0613A6 for ; Thu, 21 Oct 2021 17:05:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232187AbhJURHf (ORCPT ); Thu, 21 Oct 2021 13:07:35 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:59620 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231738AbhJURH0 (ORCPT ); Thu, 21 Oct 2021 13:07:26 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]:41572) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mdbV7-000916-Ck; Thu, 21 Oct 2021 11:05:09 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95]:57164 helo=email.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mdbV6-00CqKm-6W; Thu, 21 Oct 2021 11:05:08 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Kees Cook Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Linus Torvalds , Oleg Nesterov , Al Viro , Gabriel Krisman Bertazi , Thomas Gleixner , Peter Zijlstra , Andy Lutomirski References: <87y26nmwkb.fsf@disp2133> <20211020174406.17889-14-ebiederm@xmission.com> <202110210925.9DEAF27CA@keescook> <878rymbags.fsf@disp2133> <202110210940.3BBA18AA@keescook> Date: Thu, 21 Oct 2021 12:05:00 -0500 In-Reply-To: <202110210940.3BBA18AA@keescook> (Kees Cook's message of "Thu, 21 Oct 2021 09:40:53 -0700") Message-ID: <87bl3i8g1v.fsf@disp2133> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1mdbV6-00CqKm-6W;;;mid=<87bl3i8g1v.fsf@disp2133>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/abBs/x5uzNaMDoEejuqATALte68zrFec= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 14/20] exit/syscall_user_dispatch: Send ordinary signals on failure X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees Cook writes: > On Thu, Oct 21, 2021 at 11:37:23AM -0500, Eric W. Biederman wrote: >> Kees Cook writes: >> >> > On Wed, Oct 20, 2021 at 12:44:00PM -0500, Eric W. Biederman wrote: >> >> Use force_fatal_sig instead of calling do_exit directly. This ensures >> >> the ordinary signal handling path gets invoked, core dumps as >> >> appropriate get created, and for multi-threaded processes all of the >> >> threads are terminated not just a single thread. >> > >> > Yeah, looks good. Should be no visible behavior change. >> >> It is observable in that an entire multi-threaded process gets >> terminated instead of a single thread. But since these events should >> be handling of extra-ordinary events I don't expect there is anyone >> who wants to have a thread of their process survive. > > Right -- sorry, I should have said that more clearly: "Besides the > single thread death now taking the whole process, there's not behavior > change (i.e. the signal delivery)." Still looks good to me. Yes. I just didn't want that single vs multi-thread case to sneak up on people. Especially since that is part of the questionable behavior that I am sorting out. Eric