[Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_GCC_BUG_43744

[Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_GCC_BUG_43744

[Giulio Benetti]

gnuradio package fails to build for the SH4 architecture with optimization
enabled with gcc 9.3.0:
http://autobuild.buildroot.net/results/1db/1db6c59c98e3c09fa13277076ee2fbe7967f1f6b/    http://autobuild.buildroot.net/results/f57/f5742e7fb6e8142bcdb53b7f4f5e9c1bea3558cd/
and I've tested it shows up with gcc 10.x and 11.x

I've commented it and supplied preprocessed file to reopen it since it was
closed with gcc 4.x:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43744

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 toolchain/Config.in | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 8b01067105..cb03a56cd9 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -109,6 +109,16 @@ config BR2_TOOLCHAIN_SUPPORTS_VARIADIC_MI_THUNK
 	depends on !BR2_or1k
 	depends on !BR2_xtensa
 
+# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43744. This bug no
+# reappeared on gcc 9.x and is still not fixed on gcc 11.x
+config BR2_TOOLCHAIN_HAS_GCC_BUG_43744
+	bool
+	default y if BR2_sh4
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || \
+		BR2_TOOLCHAIN_GCC_AT_LEAST_9 || \
+		BR2_TOOLCHAIN_GCC_AT_LEAST_10 || \
+		BR2_TOOLCHAIN_GCC_AT_LEAST_11
+
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63261. This bug no
 # longer exists in gcc 8.x.
 config BR2_TOOLCHAIN_HAS_GCC_BUG_63261
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/gnuradio: disable package if affected from gcc bug 43744

[Giulio Benetti]

This package is affected by gcc bug 43744 and I have not found a work
around for it(i.e. the common -O0 we use or other), so let's disable it if
gcc has such bug.

Fixes:
http://autobuild.buildroot.net/results/1db/1db6c59c98e3c09fa13277076ee2fbe7967f1f6b/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/gnuradio/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
index 77163c611d..1896d1326a 100644
--- a/package/gnuradio/Config.in
+++ b/package/gnuradio/Config.in
@@ -4,7 +4,8 @@ comment "gnuradio needs a toolchain w/ C++, NPTL, wchar, dynamic library"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
 		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
 
-comment "gnuradio needs a toolchain not affected by GCC bug 64735"
+comment "gnuradio needs a toolchain not affected by GCC bug 43744 and 64735"
+	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_43744
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
 
 config BR2_PACKAGE_GNURADIO
@@ -15,6 +16,7 @@ config BR2_PACKAGE_GNURADIO
 	depends on BR2_USE_MMU # use fork()
 	depends on BR2_USE_WCHAR # boost
 	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-atomic, boost-filesystem
+	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_43744
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-thread
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_BOOST_ATOMIC
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_GCC_BUG_43744

[Thomas Petazzoni]

On Sat,  9 Oct 2021 00:46:04 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> gnuradio package fails to build for the SH4 architecture with optimization
> enabled with gcc 9.3.0:
> http://autobuild.buildroot.net/results/1db/1db6c59c98e3c09fa13277076ee2fbe7967f1f6b/    http://autobuild.buildroot.net/results/f57/f5742e7fb6e8142bcdb53b7f4f5e9c1bea3558cd/
> and I've tested it shows up with gcc 10.x and 11.x
> 
> I've commented it and supplied preprocessed file to reopen it since it was
> closed with gcc 4.x:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43744
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  toolchain/Config.in | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Series applied to master, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/gnuradio: disable package if affected from gcc bug 43744

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > This package is affected by gcc bug 43744 and I have not found a work
 > around for it(i.e. the common -O0 we use or other), so let's disable it if
 > gcc has such bug.

 > Fixes:
 > http://autobuild.buildroot.net/results/1db/1db6c59c98e3c09fa13277076ee2fbe7967f1f6b/

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

What about the reverse dependencies, E.G. gqrx?

package/gqrx/Config.in: select BR2_PACKAGE_GNURADIO

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/gnuradio: disable package if affected from gcc bug 43744

[Giulio Benetti]

Hello Peter,

> Il giorno 10 ott 2021, alle ore 10:23, Peter Korsgaard <peter@korsgaard.com> ha scritto:
> 
> 
>> 
>>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> 
>> This package is affected by gcc bug 43744 and I have not found a work
>> around for it(i.e. the common -O0 we use or other), so let's disable it if
>> gcc has such bug.
> 
>> Fixes:
>> http://autobuild.buildroot.net/results/1db/1db6c59c98e3c09fa13277076ee2fbe7967f1f6b/
> 
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> 
> What about the reverse dependencies, E.G. gqrx?

Sorry, every time I forget about reverse dependency. Tonight I’m going to fix it

Best regards

Giulio

> 
> package/gqrx/Config.in: select BR2_PACKAGE_GNURADIO
> 
> -- 
> Bye, Peter Korsgaard
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/gnuradio: disable package if affected from gcc bug 43744

[Thomas Petazzoni]

On Sun, 10 Oct 2021 10:23:07 +0200
Peter Korsgaard <peter@korsgaard.com> wrote:

> What about the reverse dependencies, E.G. gqrx?
> 
> package/gqrx/Config.in: select BR2_PACKAGE_GNURADIO

Gaah. I've stopped reviewing/merging Buildroot patches for too long,
and I've forgotten even the most basic checks... I'll try to be more
careful.

Giulio: I suppose you will provide a follow-up patch that addresses the
reverse dependencies?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/gnuradio: disable package if affected from gcc bug 43744

[Giulio Benetti]

> Il giorno 10 ott 2021, alle ore 16:03, Thomas Petazzoni <thomas.petazzoni@bootlin.com> ha scritto:
> 
> On Sun, 10 Oct 2021 10:23:07 +0200
> Peter Korsgaard <peter@korsgaard.com> wrote:
> 
>> What about the reverse dependencies, E.G. gqrx?
>> 
>> package/gqrx/Config.in: select BR2_PACKAGE_GNURADIO
> 
> Gaah. I've stopped reviewing/merging Buildroot patches for too long,
> and I've forgotten even the most basic checks... I'll try to be more
> careful.
> 
> Giulio: I suppose you will provide a follow-up patch that addresses the
> reverse dependencies?

Sure, tonight I’m going to send a patch. Every time I forget the reverse dependencies :-/

Giulio

> 
> Best regards,
> 
> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/gnuradio: disable package if affected from gcc bug 43744

[Giulio Benetti]

Hi Peter, Thomas, All,

On 10/10/21 10:23 AM, Peter Korsgaard wrote:
>>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> 
>   > This package is affected by gcc bug 43744 and I have not found a work
>   > around for it(i.e. the common -O0 we use or other), so let's disable it if
>   > gcc has such bug.
> 
>   > Fixes:
>   > http://autobuild.buildroot.net/results/1db/1db6c59c98e3c09fa13277076ee2fbe7967f1f6b/
> 
>   > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> 
> What about the reverse dependencies, E.G. gqrx?
> 
> package/gqrx/Config.in: select BR2_PACKAGE_GNURADIO

Here is the patch fixing reverse dependency for gnuradio:
https://patchwork.ozlabs.org/project/buildroot/patch/20211010224220.1111960-1-giulio.benetti@benettiengineering.com/

Best regards
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot