From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC9BC433F5 for ; Thu, 7 Oct 2021 20:13:30 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE05A61139 for ; Thu, 7 Oct 2021 20:13:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EE05A61139 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=buildroot.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C5755402F1; Thu, 7 Oct 2021 20:13:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9YJ7HzwiQBJT; Thu, 7 Oct 2021 20:13:29 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id F1967409FA; Thu, 7 Oct 2021 20:13:27 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id A60691BF84C for ; Thu, 7 Oct 2021 20:13:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9619B84297 for ; Thu, 7 Oct 2021 20:13:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id evvb7ov6OrnU for ; Thu, 7 Oct 2021 20:13:20 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by smtp1.osuosl.org (Postfix) with ESMTPS id BF1FC84287 for ; Thu, 7 Oct 2021 20:13:19 +0000 (UTC) Received: (Authenticated sender: peter@casa-korsgaard.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 93D09FF805; Thu, 7 Oct 2021 20:13:15 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.92) (envelope-from ) id 1mYZlS-0002Ti-NE; Thu, 07 Oct 2021 22:13:14 +0200 From: Peter Korsgaard To: Giulio Benetti References: <20211004203535.923467-1-giulio.benetti@benettiengineering.com> Date: Thu, 07 Oct 2021 22:13:14 +0200 In-Reply-To: <20211004203535.923467-1-giulio.benetti@benettiengineering.com> (Giulio Benetti's message of "Mon, 4 Oct 2021 22:35:35 +0200") Message-ID: <87bl401tlx.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH] package/mesa3d: remove unnecessary passing of CFLAGS X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernd Kuhls , Romain Naour , "Yann E . MORIN" , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Giulio" == Giulio Benetti writes: > This package uses meson-package infrastracture, so we don't need to > explicitly pass its additional CFLAGS to some variable. The only thing we > need to pass them is to use MESA3D_CFLAGS, because in package/pkg-meson.mk > we have: > $(2)_CFLAGS ?= $$(TARGET_CFLAGS) > that makes the work automatically, where $(2) is exactly the package name, > though $(2)_CFLAGS expands to MESA3D_CFLAGS. > So let's remove the MESA3D_CONF_OPTS += -DCMAKE_C_FLAGS="$(MESA3D_CFLAGS)" > line that has been added by mistake. > Note: this doesn't fix any bug, but remove an unnecessary and ambiguos line > Signed-off-by: Giulio Benetti Committed, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot