From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 480F7C4332F for ; Wed, 22 Sep 2021 21:31:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 345FB60F44 for ; Wed, 22 Sep 2021 21:31:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238042AbhIVVcr (ORCPT ); Wed, 22 Sep 2021 17:32:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:45348 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237988AbhIVVcq (ORCPT ); Wed, 22 Sep 2021 17:32:46 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E410C60E54; Wed, 22 Sep 2021 21:31:15 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mT9pi-00CPhO-21; Wed, 22 Sep 2021 22:31:14 +0100 Date: Wed, 22 Sep 2021 22:31:13 +0100 Message-ID: <87bl4kb8m6.wl-maz@kernel.org> From: Marc Zyngier To: Rob Herring Cc: Sven Peter , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , PCI , Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?UTF-8?B?V2lsY3p5xYRz?= =?UTF-8?B?a2k=?= , Alyssa Rosenzweig , Stan Skowronek , Mark Kettenis , Hector Martin , Robin Murphy , Android Kernel Team Subject: Re: [PATCH v4 04/10] PCI: apple: Add initial hardware bring-up In-Reply-To: References: <20210922205458.358517-1-maz@kernel.org> <20210922205458.358517-5-maz@kernel.org> <86507f22-d824-4f7c-ba94-d3105c5206c2@www.fastmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: robh+dt@kernel.org, sven@svenpeter.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, bhelgaas@google.com, lorenzo.pieralisi@arm.com, kw@linux.com, alyssa@rosenzweig.io, stan@corellium.com, kettenis@openbsd.org, marcan@marcan.st, Robin.Murphy@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Sep 2021 22:14:49 +0100, Rob Herring wrote: > > On Wed, Sep 22, 2021 at 4:08 PM Sven Peter wrote: > > > > Hi, > > > > > > On Wed, Sep 22, 2021, at 22:54, Marc Zyngier wrote: > > > From: Alyssa Rosenzweig > > > > > [...] > > > + > > > + /* Use the first reg entry to work out the port index */ > > > + port->idx = idx >> 11; > > > + port->pcie = pcie; > > > + port->np = np; > > > + > > > + port->base = devm_platform_ioremap_resource(platform, port->idx + 2); > > > + if (IS_ERR(port->base)) > > > + return -ENODEV; > > Don't change error codes. Yup, good point. There is another instance of that when setting up a port. > > > > + > > > + rmw_set(PORT_APPCLK_EN, port + PORT_APPCLK); > > > > I think this should be > > > > rmw_set(PORT_APPCLK_EN, port->base + PORT_APPCLK); > > Or just removed if this was tested and worked. That's probably the point where I find out that it only worked because I was corrupting memory in bizarre ways. Oh well. Thanks, M. -- Without deviation from the norm, progress is not possible.