From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F3AC4338F for ; Mon, 23 Aug 2021 14:51:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88E0761378 for ; Mon, 23 Aug 2021 14:51:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230437AbhHWOwf (ORCPT ); Mon, 23 Aug 2021 10:52:35 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:47240 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230141AbhHWOwe (ORCPT ); Mon, 23 Aug 2021 10:52:34 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id BDE0D1F4260E From: Gabriel Krisman Bertazi To: Christoph Hellwig Cc: Shreeya Patel , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 01/11] ext4: simplify ext4_sb_read_encoding Organization: Collabora References: <20210818140651.17181-1-hch@lst.de> <20210818140651.17181-2-hch@lst.de> Date: Mon, 23 Aug 2021 10:51:45 -0400 In-Reply-To: <20210818140651.17181-2-hch@lst.de> (Christoph Hellwig's message of "Wed, 18 Aug 2021 16:06:41 +0200") Message-ID: <87bl5o2ozi.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Christoph Hellwig writes: > Return the encoding table as the return value instead of as an argument, > and don't bother with the encoding flags as the caller can handle that > trivially. > > Signed-off-by: Christoph Hellwig Looks good to me. Feel free to add Reviewed-by: Gabriel Krisman Bertazi -- Gabriel Krisman Bertazi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54739C4338F for ; Mon, 23 Aug 2021 14:52:05 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA6376112F; Mon, 23 Aug 2021 14:52:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EA6376112F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mIBIx-00068g-Dk; Mon, 23 Aug 2021 14:52:03 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIBIw-00068a-KW for linux-f2fs-devel@lists.sourceforge.net; Mon, 23 Aug 2021 14:52:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=c1Es+iyquvurl4iUp76bLtGcju2n/hJC+MdzzJtUUrg=; b=JQAVdQeDZUtQ44w7ofgLoSTf0O /neF1bHgRaCA5aLgSgYrF6lr/mLaduiAm1TZCoGRgB/+aKdz7UEqut7FjrQERtkXQPNF814dtzapC WI/lmjtjiiRzXuKiSNjhbHDANsO0lspiFVhl7fRu5pLcfPXOkfoHkw8C2dncbc+gEcRc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject: Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=c1Es+iyquvurl4iUp76bLtGcju2n/hJC+MdzzJtUUrg=; b=JhOBTonIaCDau6nR5dwsffFLS9 YxIZasBvcpCFeCAShhAj/P7udYqGRxTpdG50E7jZEHi9tkcAlhi/yc5/iEaV8NcATqTVGS8aEL5XW 3wBTHZ5y9kg7dEJQhNK9KW83CrS114HhYBvLVC6RFvrUJbgINuWUKIwjjDR8joHEhK4I=; Received: from bhuna.collabora.co.uk ([46.235.227.227]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mIBIu-0001F8-CJ for linux-f2fs-devel@lists.sourceforge.net; Mon, 23 Aug 2021 14:52:02 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id BDE0D1F4260E From: Gabriel Krisman Bertazi To: Christoph Hellwig Organization: Collabora References: <20210818140651.17181-1-hch@lst.de> <20210818140651.17181-2-hch@lst.de> Date: Mon, 23 Aug 2021 10:51:45 -0400 In-Reply-To: <20210818140651.17181-2-hch@lst.de> (Christoph Hellwig's message of "Wed, 18 Aug 2021 16:06:41 +0200") Message-ID: <87bl5o2ozi.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1mIBIu-0001F8-CJ Subject: Re: [f2fs-dev] [PATCH 01/11] ext4: simplify ext4_sb_read_encoding X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Shreeya Patel , linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Christoph Hellwig writes: > Return the encoding table as the return value instead of as an argument, > and don't bother with the encoding flags as the caller can handle that > trivially. > > Signed-off-by: Christoph Hellwig Looks good to me. Feel free to add Reviewed-by: Gabriel Krisman Bertazi -- Gabriel Krisman Bertazi _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel