From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCA66C04FF3 for ; Fri, 21 May 2021 21:48:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93549613DB for ; Fri, 21 May 2021 21:48:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229541AbhEUVuO (ORCPT ); Fri, 21 May 2021 17:50:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhEUVuL (ORCPT ); Fri, 21 May 2021 17:50:11 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E727C061574; Fri, 21 May 2021 14:48:47 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1621633723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/+S8LTQNiG8i9DExgcVWsWx6U3U7vi+PRUnPuD/CDDg=; b=MpR7WhOyoJvBu9w7C3xfGoz0uwROzPNODcrPkb6Eu+Tyo5nrZ7nd0Xs3F7kllLesJ2CtCx rkuTb3JESWsKOFBUx4dFUdG4FCZG4SoziwDTEM52Y9DU7FTnJQslfOHkWKJSpnMJDGIzUU OG8f7A6FSbfF23uysmfoIeyU/DTcECF6Hxl9ur3UFtrX+m6wvQT53T7mnqupOV58JWjynY 1UiyBovgzBUTzkZZAhqZJKgksdxRXJPYQ3HEeF+wMTTPmUyjR9i3kMhLDtlgQHzMw+o8Js SHWhabAKFfs0w3j4lCJmtYNkKMxOIFZoUQIwx+puNK1XHU9mf1GX866A6b718A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1621633723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/+S8LTQNiG8i9DExgcVWsWx6U3U7vi+PRUnPuD/CDDg=; b=Ug5aL3BaELpvg/OrbwBRE30R+5KHf653uC6Z2QkOC3VWj6yCx/fkMy8YHUjo7RwS3H5JK3 QN+PDqVGRgtzb2BQ== To: Nitesh Lal Cc: Jesse Brandeburg , Robin Murphy , Marcelo Tosatti , Ingo Molnar , linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, jbrandeb@kernel.org, "frederic\@kernel.org" , "juri.lelli\@redhat.com" , Alex Belits , "linux-api\@vger.kernel.org" , "bhelgaas\@google.com" , "linux-pci\@vger.kernel.org" , "rostedt\@goodmis.org" , "peterz\@infradead.org" , "davem\@davemloft.net" , "akpm\@linux-foundation.org" , "sfr\@canb.auug.org.au" , "stephen\@networkplumber.org" , "rppt\@linux.vnet.ibm.com" , "jinyuqi\@huawei.com" , "zhangshaokun\@hisilicon.com" , netdev@vger.kernel.org, chris.friesen@windriver.com, Marc Zyngier , Neil Horman , pjwaskiewicz@gmail.com Subject: Re: [PATCH] genirq: Provide new interfaces for affinity hints In-Reply-To: References: <20210504092340.00006c61@intel.com> <87pmxpdr32.ffs@nanos.tec.linutronix.de> <87im3gewlu.ffs@nanos.tec.linutronix.de> <87zgwo9u79.ffs@nanos.tec.linutronix.de> <87wnrs9tvp.ffs@nanos.tec.linutronix.de> Date: Fri, 21 May 2021 23:48:43 +0200 Message-ID: <87bl93ahc4.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21 2021 at 12:13, Nitesh Lal wrote: > On Fri, May 21, 2021 at 8:03 AM Thomas Gleixner wrote: >> Provide new interfaces: >> >> irq_update_affinity_hint() - Only sets the affinity hint pointer >> irq_apply_affinity_hint() - Set the pointer and apply the affinity to >> the interrupt >> > > Any reason why you ruled out the usage of irq_set_affinity_and_hint()? > IMHO the latter makes it very clear what the function is meant to do. You're right. I was trying to phase the existing hint setter out, but that's probably pointless overengineering for no real value. Let me redo that. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Date: Fri, 21 May 2021 23:48:43 +0200 Subject: [Intel-wired-lan] [PATCH] genirq: Provide new interfaces for affinity hints In-Reply-To: References: <20210504092340.00006c61@intel.com> <87pmxpdr32.ffs@nanos.tec.linutronix.de> <87im3gewlu.ffs@nanos.tec.linutronix.de> <87zgwo9u79.ffs@nanos.tec.linutronix.de> <87wnrs9tvp.ffs@nanos.tec.linutronix.de> Message-ID: <87bl93ahc4.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Fri, May 21 2021 at 12:13, Nitesh Lal wrote: > On Fri, May 21, 2021 at 8:03 AM Thomas Gleixner wrote: >> Provide new interfaces: >> >> irq_update_affinity_hint() - Only sets the affinity hint pointer >> irq_apply_affinity_hint() - Set the pointer and apply the affinity to >> the interrupt >> > > Any reason why you ruled out the usage of irq_set_affinity_and_hint()? > IMHO the latter makes it very clear what the function is meant to do. You're right. I was trying to phase the existing hint setter out, but that's probably pointless overengineering for no real value. Let me redo that. Thanks, tglx