All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/{collectd, domoticz}: fix outdated dependencies for mosquitto
Date: Sat, 29 Aug 2020 19:30:37 +0200	[thread overview]
Message-ID: <87blitgy0y.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200829130339.167330-1-titouan.christophe@railnova.eu> (Titouan Christophe's message of "Sat, 29 Aug 2020 15:03:39 +0200")

>>>>> "Titouan" == Titouan Christophe <titouan.christophe@railnova.eu> writes:

 > In 4fc62e1eb6b3adbfc3d3eb7f841275ae8cd1b424, we removed arch/toolchain
 > dependencies from the mosquitto library (MMU, !STATIC, SYNC4), and moved
 > them to the mosquitto broker only.

 > All the packages modified here only need the mosquitto library, so they
 > shouldn't have those depends anymore; but this was never done before.

 > Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>
 > ---
 >  package/collectd/Config.in | 1 -
 >  package/domoticz/Config.in | 3 ---
 >  2 files changed, 4 deletions(-)

 > diff --git a/package/collectd/Config.in b/package/collectd/Config.in
 > index 4f54944cbc..ddf64015bd 100644
 > --- a/package/collectd/Config.in
 > +++ b/package/collectd/Config.in
 > @@ -607,7 +607,6 @@ comment "grpc needs a toolchain w/ C++, gcc >= 4.8"
 
 >  config BR2_PACKAGE_COLLECTD_MQTT
 >  	bool "mqtt"
 > -	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # mosquitto
 >  	select BR2_PACKAGE_MOSQUITTO
 >  	help
 >  	  Sends metrics to and/or receives metrics from an MQTT broker.
 > diff --git a/package/domoticz/Config.in b/package/domoticz/Config.in
 > index c713ac58b1..a2ad9f1b07 100644
 > --- a/package/domoticz/Config.in
 > +++ b/package/domoticz/Config.in
 > @@ -1,8 +1,5 @@
 >  config BR2_PACKAGE_DOMOTICZ
 >  	bool "domoticz"
 > -	depends on BR2_USE_MMU # mosquitto

the domoticz code has a bunch of references to fork(), so I've kept
this.

 > -	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # mosquitto
 > -	depends on !BR2_STATIC_LIBS # mosquitto

CMakeLists.txt explicitly checks for libmosquitto.so:

find_library(MQTT_LIBRARIES NAMES libmosquitto.so)

So I've left that as well.

Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2020-08-29 17:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-29 13:03 [Buildroot] [PATCH 1/1] package/{collectd, domoticz}: fix outdated dependencies for mosquitto Titouan Christophe
2020-08-29 17:30 ` Peter Korsgaard [this message]
2020-08-29 17:52 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blitgy0y.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.