All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Alcantara <pc@cjr.nz>
To: Steve French <smfrench@gmail.com>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH][SMB3] Fix mkdir when idsfromsid configured on mount
Date: Thu, 13 Aug 2020 14:55:53 -0300	[thread overview]
Message-ID: <87blje5t1y.fsf@cjr.nz> (raw)
In-Reply-To: <CAH2r5ms-cXJzTqbTuE8_095aUssB8RvaqBTkfY2gHROjg7GsAQ@mail.gmail.com>

Steve French <smfrench@gmail.com> writes:

> From c8e2d959ddac89ee44f170b2f2549e749581ec55 Mon Sep 17 00:00:00 2001
> From: Steve French <stfrench@microsoft.com>
> Date: Thu, 13 Aug 2020 12:38:08 -0500
> Subject: [PATCH] SMB3: Fix mkdir when idsfromsid configured on mount
>
> mkdir uses a compounded create operation which was not setting
> the security descriptor on create of a directory. Fix so
> mkdir now sets the mode and owner info properly when idsfromsid
> and modefromsid are configured on the mount.
>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> CC: Stable <stable@vger.kernel.org> # v5.8
> ---
>  fs/cifs/smb2inode.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fs/cifs/smb2inode.c b/fs/cifs/smb2inode.c
> index b9db73687eaa..eba01d0908dd 100644
> --- a/fs/cifs/smb2inode.c
> +++ b/fs/cifs/smb2inode.c
> @@ -115,6 +115,7 @@ smb2_compound_op(const unsigned int xid, struct cifs_tcon *tcon,
>  	vars->oparms.fid = &fid;
>  	vars->oparms.reconnect = false;
>  	vars->oparms.mode = mode;
> +	vars->oparms.cifs_sb = cifs_sb;
>  
>  	rqst[num_rqst].rq_iov = &vars->open_iov[0];
>  	rqst[num_rqst].rq_nvec = SMB2_CREATE_IOV_SIZE;

Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>

  reply	other threads:[~2020-08-13 17:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13 17:44 [PATCH][SMB3] Fix mkdir when idsfromsid configured on mount Steve French
2020-08-13 17:55 ` Paulo Alcantara [this message]
2020-08-13 23:10   ` Pavel Shilovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blje5t1y.fsf@cjr.nz \
    --to=pc@cjr.nz \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.