From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01414C38A2A for ; Thu, 7 May 2020 13:22:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCFC020870 for ; Thu, 7 May 2020 13:22:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588857758; bh=dU2Zo4Cy68Npnqp73m+WYREuX5FjtiM6YUcFyZ5Glks=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=JcDiOJl17F/QdK1AEK1zoYGHe8feCwt3XvkD2lSy8zhbhxrMIQMImEXNl4EK6wJ2c vnUirSHti91f2do2L8q7psLOHn9kavg2YO1/zc8wmt8b4hQ9yjjlv34C+tgv08umIe PxOhMhinaGjfqN0T9Y1rRI4/Kw4Y9OEDkTiF0Las= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726598AbgEGNWi (ORCPT ); Thu, 7 May 2020 09:22:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:41494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726235AbgEGNWh (ORCPT ); Thu, 7 May 2020 09:22:37 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B8A5920838; Thu, 7 May 2020 13:22:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588857756; bh=dU2Zo4Cy68Npnqp73m+WYREuX5FjtiM6YUcFyZ5Glks=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Mvxv/k6N6eZhza7DRddP/HQFLzYxG1sOPRTBagBbVSX+mWQuvMoyOdQz41Z3PkSNw oY9IRopODgKsVRXGmEjvlVkYEpRPYzNoS/8IeFzGzM6Pg/zSJNlzRW/nwfHqf6AByO 2H9Y99Vq60RECr/Ej/t+r3afxre/15Nkp/hfXcXo= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWgTz-00AGtt-4Z; Thu, 07 May 2020 14:22:35 +0100 Date: Thu, 07 May 2020 14:22:34 +0100 Message-ID: <87blmzj2w5.wl-maz@kernel.org> From: Marc Zyngier To: David Brazdil Cc: Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/15] arm64: kvm: Fix symbol dependency in __hyp_call_panic_nvhe In-Reply-To: <20200430144831.59194-4-dbrazdil@google.com> References: <20200430144831.59194-1-dbrazdil@google.com> <20200430144831.59194-4-dbrazdil@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: dbrazdil@google.com, catalin.marinas@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Apr 2020 15:48:19 +0100, David Brazdil wrote: > > __hyp_call_panic_nvhe contains inline assembly which did not declare > its dependency on the __hyp_panic_string symbol. > > Signed-off-by: David Brazdil > --- > arch/arm64/kvm/hyp/switch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/switch.c b/arch/arm64/kvm/hyp/switch.c > index 8a1e81a400e0..7a7c08029d81 100644 > --- a/arch/arm64/kvm/hyp/switch.c > +++ b/arch/arm64/kvm/hyp/switch.c > @@ -836,7 +836,7 @@ static void __hyp_text __hyp_call_panic_nvhe(u64 spsr, u64 elr, u64 par, > * making sure it is a kernel address and not a PC-relative > * reference. > */ > - asm volatile("ldr %0, =__hyp_panic_string" : "=r" (str_va)); > + asm volatile("ldr %0, =%1" : "=r" (str_va) : "S" (__hyp_panic_string)); > > __hyp_do_panic(str_va, > spsr, elr, > -- > 2.26.1 > > What breaks without this constraint? Is it a fix that should go in early? Otherwise looks good. Thanks, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C41AC38A2A for ; Thu, 7 May 2020 13:22:43 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 2A6DD20838 for ; Thu, 7 May 2020 13:22:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mvxv/k6N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A6DD20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C7FCE4B332; Thu, 7 May 2020 09:22:42 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dZzrvwyIxbOd; Thu, 7 May 2020 09:22:40 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C93F14B327; Thu, 7 May 2020 09:22:40 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D3D894B324 for ; Thu, 7 May 2020 09:22:38 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g2N1VWYoAgI6 for ; Thu, 7 May 2020 09:22:37 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id D07C04B323 for ; Thu, 7 May 2020 09:22:37 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B8A5920838; Thu, 7 May 2020 13:22:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588857756; bh=dU2Zo4Cy68Npnqp73m+WYREuX5FjtiM6YUcFyZ5Glks=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Mvxv/k6N6eZhza7DRddP/HQFLzYxG1sOPRTBagBbVSX+mWQuvMoyOdQz41Z3PkSNw oY9IRopODgKsVRXGmEjvlVkYEpRPYzNoS/8IeFzGzM6Pg/zSJNlzRW/nwfHqf6AByO 2H9Y99Vq60RECr/Ej/t+r3afxre/15Nkp/hfXcXo= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWgTz-00AGtt-4Z; Thu, 07 May 2020 14:22:35 +0100 Date: Thu, 07 May 2020 14:22:34 +0100 Message-ID: <87blmzj2w5.wl-maz@kernel.org> From: Marc Zyngier To: David Brazdil Subject: Re: [PATCH 03/15] arm64: kvm: Fix symbol dependency in __hyp_call_panic_nvhe In-Reply-To: <20200430144831.59194-4-dbrazdil@google.com> References: <20200430144831.59194-1-dbrazdil@google.com> <20200430144831.59194-4-dbrazdil@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: dbrazdil@google.com, catalin.marinas@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Catalin Marinas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thu, 30 Apr 2020 15:48:19 +0100, David Brazdil wrote: > > __hyp_call_panic_nvhe contains inline assembly which did not declare > its dependency on the __hyp_panic_string symbol. > > Signed-off-by: David Brazdil > --- > arch/arm64/kvm/hyp/switch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/switch.c b/arch/arm64/kvm/hyp/switch.c > index 8a1e81a400e0..7a7c08029d81 100644 > --- a/arch/arm64/kvm/hyp/switch.c > +++ b/arch/arm64/kvm/hyp/switch.c > @@ -836,7 +836,7 @@ static void __hyp_text __hyp_call_panic_nvhe(u64 spsr, u64 elr, u64 par, > * making sure it is a kernel address and not a PC-relative > * reference. > */ > - asm volatile("ldr %0, =__hyp_panic_string" : "=r" (str_va)); > + asm volatile("ldr %0, =%1" : "=r" (str_va) : "S" (__hyp_panic_string)); > > __hyp_do_panic(str_va, > spsr, elr, > -- > 2.26.1 > > What breaks without this constraint? Is it a fix that should go in early? Otherwise looks good. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44725C4724C for ; Thu, 7 May 2020 13:22:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16C7620870 for ; Thu, 7 May 2020 13:22:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KcY7zmIT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mvxv/k6N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16C7620870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b8vwWUA1LYHpDB0hEmUqEyAl+t2kHqemaW8zMWvmRYE=; b=KcY7zmITzr6jfN yISPsOVJpqzMJvxHm8BbCyu/qfjxxli6tY1yVGrftiNFRpcdUK/xyTdepU+d16efMXYGF5SiEyzdx 2r+MtWqSpFK+1tjJ3rEtbX5iFdJAaf+jKQGUJs9efsifgednIdN+q8Ik62qdIlEtW0zVX3nU/2cJ/ A2ogTj9V2fXEx571GgzKbSHOpMFf+0ZqYqummX8hV6/mpeZME2d62XZaEp5NVS57bBF0ARAL9FlnX bQ6VxVGG9wAbnk210NXykHbJJTL6h4jvXG6WmbMyGZTahAiwWp8Ok4uKxskigAsGbHRsL7ePDcxpy eKrPJOzs7shfMaaZR2Qw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWgU3-0007yM-I6; Thu, 07 May 2020 13:22:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWgU1-0007xh-8k for linux-arm-kernel@lists.infradead.org; Thu, 07 May 2020 13:22:38 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B8A5920838; Thu, 7 May 2020 13:22:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588857756; bh=dU2Zo4Cy68Npnqp73m+WYREuX5FjtiM6YUcFyZ5Glks=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Mvxv/k6N6eZhza7DRddP/HQFLzYxG1sOPRTBagBbVSX+mWQuvMoyOdQz41Z3PkSNw oY9IRopODgKsVRXGmEjvlVkYEpRPYzNoS/8IeFzGzM6Pg/zSJNlzRW/nwfHqf6AByO 2H9Y99Vq60RECr/Ej/t+r3afxre/15Nkp/hfXcXo= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWgTz-00AGtt-4Z; Thu, 07 May 2020 14:22:35 +0100 Date: Thu, 07 May 2020 14:22:34 +0100 Message-ID: <87blmzj2w5.wl-maz@kernel.org> From: Marc Zyngier To: David Brazdil Subject: Re: [PATCH 03/15] arm64: kvm: Fix symbol dependency in __hyp_call_panic_nvhe In-Reply-To: <20200430144831.59194-4-dbrazdil@google.com> References: <20200430144831.59194-1-dbrazdil@google.com> <20200430144831.59194-4-dbrazdil@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: dbrazdil@google.com, catalin.marinas@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_062237_335101_1AA8911C X-CRM114-Status: GOOD ( 18.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki K Poulose , Catalin Marinas , linux-kernel@vger.kernel.org, James Morse , linux-arm-kernel@lists.infradead.org, Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 30 Apr 2020 15:48:19 +0100, David Brazdil wrote: > > __hyp_call_panic_nvhe contains inline assembly which did not declare > its dependency on the __hyp_panic_string symbol. > > Signed-off-by: David Brazdil > --- > arch/arm64/kvm/hyp/switch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/switch.c b/arch/arm64/kvm/hyp/switch.c > index 8a1e81a400e0..7a7c08029d81 100644 > --- a/arch/arm64/kvm/hyp/switch.c > +++ b/arch/arm64/kvm/hyp/switch.c > @@ -836,7 +836,7 @@ static void __hyp_text __hyp_call_panic_nvhe(u64 spsr, u64 elr, u64 par, > * making sure it is a kernel address and not a PC-relative > * reference. > */ > - asm volatile("ldr %0, =__hyp_panic_string" : "=r" (str_va)); > + asm volatile("ldr %0, =%1" : "=r" (str_va) : "S" (__hyp_panic_string)); > > __hyp_do_panic(str_va, > spsr, elr, > -- > 2.26.1 > > What breaks without this constraint? Is it a fix that should go in early? Otherwise looks good. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel