From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65829C4BA24 for ; Thu, 27 Feb 2020 02:01:11 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC13320658 for ; Thu, 27 Feb 2020 02:01:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="p+Fc8mZ/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC13320658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 411EA15E2; Thu, 27 Feb 2020 03:00:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 411EA15E2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582768869; bh=V0jNxTWmHffiNQWZpMMagJEaAT1ZJPRU5TcdBzrObvI=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=p+Fc8mZ/T+RgQPOM5coV7xEeWgnRdVGtwTcR8MYvehJrwkK4UnqWNJxP84n7vjx53 MY4/VUtClrwV4/woNw98IJK16HDrmOvCKFr8sUcHJrqqJjC/8crhg7Z8qX0zsM/PSR k98wlzOGYrgzQ9gXLGNeG0PYDdjoEFR/sTS1kqFc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C5ED0F8014D; Thu, 27 Feb 2020 03:00:18 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7554AF8014E; Thu, 27 Feb 2020 03:00:17 +0100 (CET) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id EDF24F800AD for ; Thu, 27 Feb 2020 03:00:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EDF24F800AD Date: 27 Feb 2020 11:00:11 +0900 X-IronPort-AV: E=Sophos;i="5.70,490,1574089200"; d="scan'208";a="40146777" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 27 Feb 2020 11:00:11 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 6641E4153426; Thu, 27 Feb 2020 11:00:11 +0900 (JST) Message-ID: <87blpk7psk.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Pierre-Louis Bossart Subject: Re: [PATCH 6/8] ASoC: soc-pcm: check DAI's activity more simply In-Reply-To: References: <87eeuh97k4.wl-kuninori.morimoto.gx@renesas.com> <875zft97i4.wl-kuninori.morimoto.gx@renesas.com> <704a2cb1-ebcd-d433-0b8a-0f8d97d72fa5@linux.intel.com> <87v9ns7tpk.wl-kuninori.morimoto.gx@renesas.com> <87tv3c7tc5.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/25.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: Linux-ALSA , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Pierre-Louis > Not in this case though, the initial idea was to do the mute when only > playback or capture were enabled? If you mute when both are enabled > then that's a real change. Let's check original if ((playback && playback_active == 1) || (!playback && capture_active == 1)) snd_soc_dai_digital_mute(...) It calls mute if Playback or Capture is working. and my patch (v2) is if (codec_dai->activity) snd_soc_dai_digital_mute(...) It calls mute if Codec DAI is working (= Playback or Capture). I think it doesn't change behavior. Thank you for your help !! Best regards --- Kuninori Morimoto