All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/mender-grubenv: fix installation with genimage.sh script
Date: Fri, 10 Jan 2020 20:53:13 +0100	[thread overview]
Message-ID: <87blrbks0m.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200106230150.77830bc0@windsurf> (Thomas Petazzoni's message of "Mon, 6 Jan 2020 23:01:50 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Mon,  2 Sep 2019 15:34:41 -0700
 > aduskett at gmail.com wrote:

 >> From: Adam Duskett <aduskett@greenlots.com>
 >> 
 >> mender-grubenv currently has 3 problems that prevent an x86_64-efi image from
 >> successfully being made with the genimage.sh script.
 >> 
 >> - mender-grubenv does not currently depend on Grub2.
 >> While Grub2 is not needed to build the mender-grubenv package, Grub2 needs
 >> to be built first for mender-grubenv to overwrite the default Grub2 files
 >> reliably.
 >> 
 >> - The MENDER_GRUBENV_ENV_DIR variable points to /boot/efi/EFI/BOOT instead of
 >> /boot/EFI/BOOT, which is where the Grub2 package installs the default files.
 >> This variable now points to the correct location.
 >> 
 >> - The Grub2 package installs images to $(BINARIES_DIR)/efi-part, which the
 >> mender-grubenv package currently does not do. As such; the default Grub2
 >> configuration file is used instead of the one provided by mender-grubenv.
 >> Adding a MENDER_GRUBENV_INSTALL_IMAGES_CMDS define in mender-grubenv.mk which
 >> copies the installed files from $(TARGET_DIR)/boot/EFI to
 >> $(BINARIES_DIR)/efi-part fixes this issue.
 >> 
 >> Signed-off-by: Adam Duskett <aduskett@greenlots.com>
 >> ---
 >> package/mender-grubenv/mender-grubenv.mk | 12 +++++++++++-
 >> 1 file changed, 11 insertions(+), 1 deletion(-)

 > Applied to master with the following changes:

 >     [Thomas:
 >      - drop "runtime" on the depends on BR2_TARGET_GRUB2 since we now have
 >        a build-time dependency on it
 >      - explicitly copy the files installed by mender-grubenv in
 >        MENDER_GRUBENV_INSTALL_IMAGES_CMDS instead of blindly copying
 >        everything that is in $(TARGET_DIR)/boot/EFI]

Committed to 2019.11.x, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2020-01-10 19:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-02 22:34 [Buildroot] [PATCH v2] package/mender-grubenv: fix installation with genimage.sh script aduskett at gmail.com
2019-09-02 22:34 ` [Buildroot] [PATCH v2] board/mender: add a mender board example configuration aduskett at gmail.com
2020-01-06 22:01 ` [Buildroot] [PATCH v2] package/mender-grubenv: fix installation with genimage.sh script Thomas Petazzoni
2020-01-10 19:53   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blrbks0m.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.