From: Jani Nikula <jani.nikula@linux.intel.com>
To: Tom Murphy <murphyt7@tcd.ie>, iommu@lists.linux-foundation.org
Cc: Heiko Stuebner <heiko@sntech.de>,
kvm@vger.kernel.org, David Airlie <airlied@linux.ie>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
dri-devel@lists.freedesktop.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-tegra@vger.kernel.org, Julien Grall <julien.grall@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Will Deacon <will@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
linux-samsung-soc@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Joerg Roedel <joro@8bytes.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-rockchip@lists.infradead.org,
Andy Gross <agross@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Eric Auger <eric.auger@redhat.com>,
linux-mediatek@lis
Subject: Re: [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api
Date: Mon, 23 Dec 2019 12:37:47 +0200 [thread overview]
Message-ID: <87blrzwcn8.fsf__38869.4798968331$1577097501$gmane$org@intel.com> (raw)
In-Reply-To: <20191221150402.13868-1-murphyt7@tcd.ie>
On Sat, 21 Dec 2019, Tom Murphy <murphyt7@tcd.ie> wrote:
> This patchset converts the intel iommu driver to the dma-iommu api.
>
> While converting the driver I exposed a bug in the intel i915 driver
> which causes a huge amount of artifacts on the screen of my
> laptop. You can see a picture of it here:
> https://github.com/pippy360/kernelPatches/blob/master/IMG_20191219_225922.jpg
>
> This issue is most likely in the i915 driver and is most likely caused
> by the driver not respecting the return value of the
> dma_map_ops::map_sg function. You can see the driver ignoring the
> return value here:
> https://github.com/torvalds/linux/blob/7e0165b2f1a912a06e381e91f0f4e495f4ac3736/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c#L51
>
> Previously this didn’t cause issues because the intel map_sg always
> returned the same number of elements as the input scatter gather list
> but with the change to this dma-iommu api this is no longer the
> case. I wasn’t able to track the bug down to a specific line of code
> unfortunately.
>
> Could someone from the intel team look at this?
Let me get this straight. There is current API that on success always
returns the same number of elements as the input scatter gather
list. You propose to change the API so that this is no longer the case?
A quick check of various dma_map_sg() calls in the kernel seems to
indicate checking for 0 for errors and then ignoring the non-zero return
is a common pattern. Are you sure it's okay to make the change you're
proposing?
Anyway, due to the time of year and all, I'd like to ask you to file a
bug against i915 at [1] so this is not forgotten, and please let's not
merge the changes before this is resolved.
Thanks,
Jani.
[1] https://gitlab.freedesktop.org/drm/intel/issues/new
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2019-12-23 10:37 UTC|newest]
Thread overview: 287+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 15:03 [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [PATCH 1/8] iommu/vt-d: clean up 32bit si_domain assignment Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 23:46 ` Arvind Sankar
2019-12-21 23:46 ` [Intel-gfx] " Arvind Sankar
2019-12-21 23:46 ` Arvind Sankar
2019-12-21 23:46 ` Arvind Sankar
2019-12-21 23:46 ` Arvind Sankar
2019-12-21 23:46 ` Arvind Sankar
2019-12-21 23:46 ` Arvind Sankar
2019-12-23 3:00 ` Lu Baolu
2019-12-23 3:00 ` [Intel-gfx] " Lu Baolu
2019-12-23 3:00 ` Lu Baolu
2019-12-23 3:00 ` Lu Baolu
2019-12-23 3:00 ` Lu Baolu
2019-12-23 3:00 ` Lu Baolu
2019-12-23 3:00 ` Lu Baolu
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [PATCH 2/8] iommu/vt-d: Use default dma_direct_* mapping functions for direct mapped devices Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [PATCH 3/8] iommu/vt-d: Remove IOVA handling code from non-dma_ops path Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2020-03-20 6:30 ` Tom Murphy
2020-03-20 6:30 ` [Intel-gfx] " Tom Murphy
2020-03-20 6:30 ` Tom Murphy
2020-03-20 6:30 ` Tom Murphy
2020-03-20 6:30 ` Tom Murphy
2020-03-20 6:30 ` Tom Murphy
2020-03-20 6:30 ` Tom Murphy
2020-03-20 7:06 ` Lu Baolu
2020-03-20 7:06 ` [Intel-gfx] " Lu Baolu
2020-03-20 7:06 ` Lu Baolu
2020-03-20 7:06 ` Lu Baolu
2020-03-20 7:06 ` Lu Baolu
2020-03-20 7:06 ` Lu Baolu
2020-03-20 7:06 ` Lu Baolu
2019-12-21 15:03 ` [PATCH 4/8] iommu: Handle freelists when using deferred flushing in iommu drivers Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [PATCH 5/8] iommu: Add iommu_dma_free_cpu_cached_iovas function Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [PATCH 6/8] iommu: allow the dma-iommu api to use bounce buffers Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` [Intel-gfx] " kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-21 15:03 ` [PATCH 7/8] iommu/vt-d: Convert intel iommu driver to the iommu ops Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:04 ` [PATCH 8/8] DO NOT MERGE: iommu: disable list appending in dma-iommu Tom Murphy
2019-12-21 15:04 ` Tom Murphy
2019-12-21 15:04 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:04 ` Tom Murphy
2019-12-21 15:04 ` Tom Murphy
2019-12-21 15:04 ` Tom Murphy
2019-12-21 15:04 ` Tom Murphy
2019-12-21 15:04 ` Tom Murphy
2019-12-22 2:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Convert the intel iommu driver to the dma-iommu api Patchwork
2019-12-22 3:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2019-12-23 10:37 ` [PATCH 0/8] " Jani Nikula
2019-12-23 10:37 ` [Intel-gfx] " Jani Nikula
2019-12-23 10:37 ` Jani Nikula
2019-12-23 10:37 ` Jani Nikula
2019-12-23 10:37 ` Jani Nikula
2019-12-23 10:37 ` Jani Nikula
2019-12-23 10:37 ` Jani Nikula
2019-12-23 10:37 ` Jani Nikula
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:29 ` [Intel-gfx] " Robin Murphy
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:41 ` Jani Nikula
2019-12-23 11:41 ` [Intel-gfx] " Jani Nikula
2019-12-23 11:41 ` Jani Nikula
2019-12-23 11:41 ` Jani Nikula
2019-12-23 11:41 ` Jani Nikula
2019-12-23 11:41 ` Jani Nikula
2019-12-23 11:41 ` Jani Nikula
[not found] ` <87o8vzuv4i.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2020-03-20 6:28 ` Tom Murphy
2020-03-20 6:28 ` [Intel-gfx] " Tom Murphy
2020-03-20 6:28 ` Tom Murphy
2020-03-20 6:28 ` Tom Murphy
2020-03-20 6:28 ` Tom Murphy
2020-03-20 6:28 ` Tom Murphy
2020-03-20 6:28 ` Tom Murphy
2019-12-23 11:41 ` Jani Nikula
2019-12-23 10:37 ` Jani Nikula [this message]
2020-05-29 0:00 ` Logan Gunthorpe
2020-05-29 0:00 ` [Intel-gfx] " Logan Gunthorpe
2020-05-29 0:00 ` Logan Gunthorpe
2020-05-29 0:00 ` Logan Gunthorpe
2020-05-29 0:00 ` Logan Gunthorpe
2020-05-29 0:00 ` Logan Gunthorpe
2020-05-29 0:00 ` Logan Gunthorpe
2020-05-29 12:45 ` Christoph Hellwig
2020-05-29 12:45 ` [Intel-gfx] " Christoph Hellwig
2020-05-29 12:45 ` Christoph Hellwig
2020-05-29 12:45 ` Christoph Hellwig
2020-05-29 12:45 ` Christoph Hellwig
2020-05-29 12:45 ` Christoph Hellwig
2020-05-29 19:05 ` Logan Gunthorpe
2020-05-29 19:05 ` [Intel-gfx] " Logan Gunthorpe
2020-05-29 19:05 ` Logan Gunthorpe
2020-05-29 19:05 ` Logan Gunthorpe
2020-05-29 19:05 ` Logan Gunthorpe
2020-05-29 19:05 ` Logan Gunthorpe
2020-05-29 19:05 ` Logan Gunthorpe
[not found] ` <33137cfb-603c-86e8-1091-f36117ecfaf3-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2020-05-29 21:11 ` Marek Szyprowski
2020-05-29 21:11 ` [Intel-gfx] " Marek Szyprowski
2020-05-29 21:11 ` Marek Szyprowski
2020-05-29 21:11 ` Marek Szyprowski
2020-05-29 21:11 ` Marek Szyprowski
2020-05-29 21:11 ` Marek Szyprowski
2020-05-29 21:11 ` Marek Szyprowski
2020-05-29 21:21 ` Logan Gunthorpe
2020-05-29 21:21 ` [Intel-gfx] " Logan Gunthorpe
2020-05-29 21:21 ` Logan Gunthorpe
2020-05-29 21:21 ` Logan Gunthorpe
2020-05-29 21:21 ` Logan Gunthorpe
2020-05-29 21:21 ` Logan Gunthorpe
2020-05-29 21:21 ` Logan Gunthorpe
2020-08-24 0:04 ` Tom Murphy
2020-08-24 0:04 ` [Intel-gfx] " Tom Murphy
2020-08-24 0:04 ` Tom Murphy
2020-08-24 0:04 ` Tom Murphy
2020-08-24 0:04 ` Tom Murphy
2020-08-24 0:04 ` Tom Murphy
2020-08-24 0:04 ` Tom Murphy
2020-08-24 0:04 ` Tom Murphy
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` [Intel-gfx] " Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-27 21:36 ` Logan Gunthorpe
2020-08-27 21:36 ` [Intel-gfx] " Logan Gunthorpe
2020-08-27 21:36 ` Logan Gunthorpe
2020-08-27 21:36 ` Logan Gunthorpe
2020-08-27 21:36 ` Logan Gunthorpe
2020-08-27 21:36 ` Logan Gunthorpe
2020-08-27 21:36 ` Logan Gunthorpe
2020-08-27 23:34 ` Tom Murphy
2020-08-27 23:34 ` [Intel-gfx] " Tom Murphy
2020-08-27 23:34 ` Tom Murphy
2020-08-27 23:34 ` Tom Murphy
2020-08-27 23:34 ` Tom Murphy
2020-08-27 23:34 ` Tom Murphy
2020-08-27 23:34 ` Tom Murphy
2020-08-27 23:34 ` Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-03 20:26 ` [Intel-gfx] " Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-08 15:28 ` [Intel-gfx] " Tvrtko Ursulin
2020-09-08 15:28 ` Tvrtko Ursulin
2020-09-08 15:28 ` Tvrtko Ursulin
2020-09-08 15:28 ` Tvrtko Ursulin
2020-09-08 15:28 ` Tvrtko Ursulin
2020-09-08 15:28 ` Tvrtko Ursulin
2020-09-08 15:28 ` Tvrtko Ursulin
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:56 ` Tvrtko Ursulin
2020-09-08 15:56 ` Tvrtko Ursulin
2020-09-08 15:56 ` Tvrtko Ursulin
2020-09-08 15:56 ` Tvrtko Ursulin
2020-09-08 15:56 ` Tvrtko Ursulin
2020-09-08 15:56 ` Tvrtko Ursulin
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 12:55 ` Tvrtko Ursulin
2020-09-09 12:55 ` Tvrtko Ursulin
2020-09-09 12:55 ` Tvrtko Ursulin
2020-09-09 12:55 ` Tvrtko Ursulin
2020-09-09 12:55 ` Tvrtko Ursulin
2020-09-09 12:55 ` Tvrtko Ursulin
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:14 ` [Intel-gfx] " Robin Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:23 ` Tom Murphy
2020-08-26 18:23 ` [Intel-gfx] " Tom Murphy
2020-08-26 18:23 ` Tom Murphy
2020-08-26 18:23 ` Tom Murphy
-- strict thread matches above, loose matches on Subject: below --
2019-12-21 15:03 Tom Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87blrzwcn8.fsf__38869.4798968331$1577097501$gmane$org@intel.com' \
--to=jani.nikula@linux.intel.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric.auger@redhat.com \
--cc=heiko@sntech.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=joro@8bytes.org \
--cc=julien.grall@arm.com \
--cc=krzk@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lis \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maz@kernel.org \
--cc=murphyt7@tcd.ie \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.