From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEFA1C388F3 for ; Tue, 1 Oct 2019 09:42:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89EFF215EA for ; Tue, 1 Oct 2019 09:42:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728469AbfJAJmm (ORCPT ); Tue, 1 Oct 2019 05:42:42 -0400 Received: from mga01.intel.com ([192.55.52.88]:41327 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbfJAJmm (ORCPT ); Tue, 1 Oct 2019 05:42:42 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2019 02:42:41 -0700 X-IronPort-AV: E=Sophos;i="5.64,570,1559545200"; d="scan'208";a="185132814" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2019 02:42:37 -0700 From: Jani Nikula To: Greg Kroah-Hartman Cc: Rasmus Villemoes , linux-kernel@vger.kernel.org, Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, Vishal Kulkarni , netdev@vger.kernel.org, linux-usb@vger.kernel.org, Andrew Morton , Julia Lawall Subject: Re: [PATCH v3] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers In-Reply-To: <20191001093849.GA2945163@kroah.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <8e697984-03b5-44f3-304e-42d303724eaa@rasmusvillemoes.dk> <20191001080739.18513-1-jani.nikula@intel.com> <20191001093849.GA2945163@kroah.com> Date: Tue, 01 Oct 2019 12:42:34 +0300 Message-ID: <87blv0dcol.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 01 Oct 2019, Greg Kroah-Hartman wrote: > On Tue, Oct 01, 2019 at 11:07:39AM +0300, Jani Nikula wrote: >> The kernel has plenty of ternary operators to choose between constant >> strings, such as condition ? "yes" : "no", as well as value == 1 ? "" : >> "s": >> >> $ git grep '? "yes" : "no"' | wc -l >> 258 >> $ git grep '? "on" : "off"' | wc -l >> 204 >> $ git grep '? "enabled" : "disabled"' | wc -l >> 196 >> $ git grep '? "" : "s"' | wc -l >> 25 >> >> Additionally, there are some occurences of the same in reverse order, >> split to multiple lines, or otherwise not caught by the simple grep. >> >> Add helpers to return the constant strings. Remove existing equivalent >> and conflicting functions in i915, cxgb4, and USB core. Further >> conversion can be done incrementally. >> >> While the main goal here is to abstract recurring patterns, and slightly >> clean up the code base by not open coding the ternary operators, there >> are also some space savings to be had via better string constant >> pooling. >> >> Cc: Joonas Lahtinen >> Cc: Rodrigo Vivi >> Cc: intel-gfx@lists.freedesktop.org >> Cc: Vishal Kulkarni >> Cc: netdev@vger.kernel.org >> Cc: Greg Kroah-Hartman >> Cc: linux-usb@vger.kernel.org >> Cc: Andrew Morton >> Cc: linux-kernel@vger.kernel.org >> Cc: Julia Lawall >> Cc: Rasmus Villemoes >> Reviewed-by: Greg Kroah-Hartman # v1 > > As this is a totally different version, please drop my reviewed-by as > that's really not true here :( I did indicate it was for v1. Indeed v2 was different, but care to elaborate what's wrong with v3? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v3] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers Date: Tue, 01 Oct 2019 12:42:34 +0300 Message-ID: <87blv0dcol.fsf@intel.com> References: <8e697984-03b5-44f3-304e-42d303724eaa@rasmusvillemoes.dk> <20191001080739.18513-1-jani.nikula@intel.com> <20191001093849.GA2945163@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3563889BA3 for ; Tue, 1 Oct 2019 09:42:42 +0000 (UTC) In-Reply-To: <20191001093849.GA2945163@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, Rasmus Villemoes , linux-kernel@vger.kernel.org, Julia Lawall , Vishal Kulkarni , Andrew Morton List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAwMSBPY3QgMjAxOSwgR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3Vu ZGF0aW9uLm9yZz4gd3JvdGU6Cj4gT24gVHVlLCBPY3QgMDEsIDIwMTkgYXQgMTE6MDc6MzlBTSAr MDMwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IFRoZSBrZXJuZWwgaGFzIHBsZW50eSBvZiB0ZXJu YXJ5IG9wZXJhdG9ycyB0byBjaG9vc2UgYmV0d2VlbiBjb25zdGFudAo+PiBzdHJpbmdzLCBzdWNo IGFzIGNvbmRpdGlvbiA/ICJ5ZXMiIDogIm5vIiwgYXMgd2VsbCBhcyB2YWx1ZSA9PSAxID8gIiIg Ogo+PiAicyI6Cj4+IAo+PiAkIGdpdCBncmVwICc/ICJ5ZXMiIDogIm5vIicgfCB3YyAtbAo+PiAy NTgKPj4gJCBnaXQgZ3JlcCAnPyAib24iIDogIm9mZiInIHwgd2MgLWwKPj4gMjA0Cj4+ICQgZ2l0 IGdyZXAgJz8gImVuYWJsZWQiIDogImRpc2FibGVkIicgfCB3YyAtbAo+PiAxOTYKPj4gJCBnaXQg Z3JlcCAnPyAiIiA6ICJzIicgfCB3YyAtbAo+PiAyNQo+PiAKPj4gQWRkaXRpb25hbGx5LCB0aGVy ZSBhcmUgc29tZSBvY2N1cmVuY2VzIG9mIHRoZSBzYW1lIGluIHJldmVyc2Ugb3JkZXIsCj4+IHNw bGl0IHRvIG11bHRpcGxlIGxpbmVzLCBvciBvdGhlcndpc2Ugbm90IGNhdWdodCBieSB0aGUgc2lt cGxlIGdyZXAuCj4+IAo+PiBBZGQgaGVscGVycyB0byByZXR1cm4gdGhlIGNvbnN0YW50IHN0cmlu Z3MuIFJlbW92ZSBleGlzdGluZyBlcXVpdmFsZW50Cj4+IGFuZCBjb25mbGljdGluZyBmdW5jdGlv bnMgaW4gaTkxNSwgY3hnYjQsIGFuZCBVU0IgY29yZS4gRnVydGhlcgo+PiBjb252ZXJzaW9uIGNh biBiZSBkb25lIGluY3JlbWVudGFsbHkuCj4+IAo+PiBXaGlsZSB0aGUgbWFpbiBnb2FsIGhlcmUg aXMgdG8gYWJzdHJhY3QgcmVjdXJyaW5nIHBhdHRlcm5zLCBhbmQgc2xpZ2h0bHkKPj4gY2xlYW4g dXAgdGhlIGNvZGUgYmFzZSBieSBub3Qgb3BlbiBjb2RpbmcgdGhlIHRlcm5hcnkgb3BlcmF0b3Jz LCB0aGVyZQo+PiBhcmUgYWxzbyBzb21lIHNwYWNlIHNhdmluZ3MgdG8gYmUgaGFkIHZpYSBiZXR0 ZXIgc3RyaW5nIGNvbnN0YW50Cj4+IHBvb2xpbmcuCj4+IAo+PiBDYzogSm9vbmFzIExhaHRpbmVu IDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+PiBDYzogUm9kcmlnbyBWaXZpIDxy b2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+PiBDYzogaW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+PiBDYzogVmlzaGFsIEt1bGthcm5pIDx2aXNoYWxAY2hlbHNpby5jb20+Cj4+IENjOiBu ZXRkZXZAdmdlci5rZXJuZWwub3JnCj4+IENjOiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBs aW51eGZvdW5kYXRpb24ub3JnPgo+PiBDYzogbGludXgtdXNiQHZnZXIua2VybmVsLm9yZwo+PiBD YzogQW5kcmV3IE1vcnRvbiA8YWtwbUBsaW51eC1mb3VuZGF0aW9uLm9yZz4KPj4gQ2M6IGxpbnV4 LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcKPj4gQ2M6IEp1bGlhIExhd2FsbCA8anVsaWEubGF3YWxs QGxpcDYuZnI+Cj4+IENjOiBSYXNtdXMgVmlsbGVtb2VzIDxsaW51eEByYXNtdXN2aWxsZW1vZXMu ZGs+Cj4+IFJldmlld2VkLWJ5OiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5k YXRpb24ub3JnPiAjIHYxCj4KPiBBcyB0aGlzIGlzIGEgdG90YWxseSBkaWZmZXJlbnQgdmVyc2lv biwgcGxlYXNlIGRyb3AgbXkgcmV2aWV3ZWQtYnkgYXMKPiB0aGF0J3MgcmVhbGx5IG5vdCB0cnVl IGhlcmUgOigKCkkgZGlkIGluZGljYXRlIGl0IHdhcyBmb3IgdjEuIEluZGVlZCB2MiB3YXMgZGlm ZmVyZW50LCBidXQgY2FyZSB0bwplbGFib3JhdGUgd2hhdCdzIHdyb25nIHdpdGggdjM/CgpCUiwK SmFuaS4KCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRl cgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=