Re: [Qemu-devel] [PATCH v2] vl.c: print error message if load fw_cfg file failed

[Markus Armbruster <armbru@redhat.com>]

Li Qiang <liq3ea@gmail.com> writes:

> Hello  Philippe,
>
> Philippe Mathieu-Daudé <philmd@redhat.com> 于2018年10月9日周二 下午1:52写道：
>
>> Hi Li,
>>
>> On 09/10/2018 04:39, Li Qiang wrote:
>> > It makes sense to print the error message while reading
>> > file failed.
[...]
>> > diff --git a/vl.c b/vl.c
>> > index 4e25c78..69fc77c 100644
>> > --- a/vl.c
>> > +++ b/vl.c
>> > @@ -2207,8 +2207,10 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts, Error **errp)
>> >          size = strlen(str); /* NUL terminator NOT included in fw_cfg blob */
>> >          buf = g_memdup(str, size);
>> >      } else {
>> > -        if (!g_file_get_contents(file, &buf, &size, NULL)) {
>> > -            error_report("can't load %s", file);
>> > +        GError *error = NULL;
>> > +        if (!g_file_get_contents(file, &buf, &size, &error)) {
>> > +            error_report("can't load %s, %s", file, error->message);
>>
>> If you ever respin, you can help Markus [1] effort using:
>>
>>             error_setg(errp, "can't load %s, %s", file, error->message);
>>
>> Else your patch will clash with [2].
>>
>
> OK, I will send out this patch based Markus' tree or later when his patch
> goes to upstream.

Appreciated!