Re: [balbi-usb:testing/next 45/57] drivers/usb/dwc2/core.c:438:13: error: static declaration of 'dwc2_clear_force_mode' follows non-static declaration

[Felipe Balbi <felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]


Hi,

kbuild test robot <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> writes:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
> head:   65223a0ed97c8c4b18c4899653745058f87d67e3
> commit: 4caf1fe8fb537388810a4c8fecfa5324b26f80ea [45/57] usb: dwc2: Make dwc2_force_mode() static
> config: i386-randconfig-x072-201806 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
>         git checkout 4caf1fe8fb537388810a4c8fecfa5324b26f80ea
>         # save the attached .config to linux build tree
>         make ARCH=i386 
>
> All errors (new ones prefixed by >>):
>
>>> drivers/usb/dwc2/core.c:438:13: error: static declaration of 'dwc2_clear_force_mode' follows non-static declaration
>     static void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg)
>                 ^~~~~~~~~~~~~~~~~~~~~
>    In file included from drivers/usb/dwc2/core.c:57:0:
>    drivers/usb/dwc2/core.h:1101:6: note: previous declaration of 'dwc2_clear_force_mode' was here
>     void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg);
>          ^~~~~~~~~~~~~~~~~~~~~
>
> vim +/dwc2_clear_force_mode +438 drivers/usb/dwc2/core.c
>
>    428	
>    429	/**
>    430	 * dwc2_clear_force_mode() - Clears the force mode bits.
>    431	 *
>    432	 * After clearing the bits, wait up to 100 ms to account for any
>    433	 * potential IDDIG filter delay. We can't know if we expect this delay
>    434	 * or not because the value of the connector ID status is affected by
>    435	 * the force mode. We only need to call this once during probe if
>    436	 * dr_mode == OTG.
>    437	 */
>  > 438	static void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg)

patch dropped.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]