From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751272AbdARIek convert rfc822-to-8bit (ORCPT ); Wed, 18 Jan 2017 03:34:40 -0500 Received: from mga11.intel.com ([192.55.52.93]:3317 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbdARIej (ORCPT ); Wed, 18 Jan 2017 03:34:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,248,1477983600"; d="scan'208";a="810254415" From: Jani Nikula To: Sreedhar Donelli , daniel.vetter@intel.com, linux-kernel@vger.kernel.org Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: drm/i915: avoid "may be used uninitialized" warnings In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Wed, 18 Jan 2017 10:31:09 +0200 Message-ID: <87bmv44vn6.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Jan 2017, Sreedhar Donelli wrote: > compilation issue on kernel-4.10-rc4 is resolved and i created a patch file. > please find the attachment for patch file. There are several issues with this contribution. Please learn to use git send-email to send your patches. Don't attach them. You need to write a proper commit message. That commit message needs to include a Signed-off-by tag. You absolutely can't have a disclaimer about confidential/privileged with the patch. See Documentation/process/submitting-patches.rst. On the content, there are no issues in the code, the compiler just seems unable to figure it out. If we were to "fix" this, for sure we don't need the superfluous changes included in this patch. BR, Jani. > > I have taken this issue from below link > > https://lkml.org/lkml/2017/1/16/89 > > > > Thanks & Regards > Sreedhar Donelli > Tata Consultancy Services > Ph:-   +91 8019039399 > Cell:- +91 8019039399 > Mailto: sreedhar.donelli@tcs.com > Website: http://www.tcs.com > ____________________________________________ > Experience certainty. IT Services > Business Solutions > Consulting > ____________________________________________ > > =====-----=====-----===== > Notice: The information contained in this e-mail > message and/or attachments to it may contain > confidential or privileged information. If you are > not the intended recipient, any dissemination, use, > review, distribution, printing or copying of the > information contained in this e-mail message > and/or attachments to it are strictly prohibited. If > you have received this communication in error, > please notify us by reply e-mail or telephone and > immediately and permanently delete the message > and any attachments. Thank you > > > diff -uNr a/linux/drivers/gpu/drm/i915/i915_gem_gtt.c b/linux/drivers/gpu/drm/i915/i915_gem_gtt.c > --- a/linux/drivers/gpu/drm/i915/i915_gem_gtt.c 2017-01-17 18:18:56.564887392 +0530 > +++ b/linux/drivers/gpu/drm/i915/i915_gem_gtt.c 2017-01-17 19:18:50.524978315 +0530 > @@ -2364,7 +2364,7 @@ > struct i915_ggtt *ggtt = i915_vm_to_ggtt(vm); > struct sgt_iter sgt_iter; > gen8_pte_t __iomem *gtt_entries; > - gen8_pte_t gtt_entry; > + gen8_pte_t gtt_entry = I915_NULL_PTE; > dma_addr_t addr; > int rpm_atomic_seq; > int i = 0; > @@ -2385,8 +2385,10 @@ > * of NUMA access patterns. Therefore, even with the way we assume > * hardware should work, we must keep this posting read for paranoia. > */ > - if (i != 0) > + if (i != 0){ > + gen8_pte_t last_gtt_entry = readq(>t_entries[i-1]); > WARN_ON(readq(>t_entries[i-1]) != gtt_entry); > + } > > /* This next bit makes the above posting read even more important. We > * want to flush the TLBs only after we're certain all the PTE updates > @@ -2439,7 +2441,7 @@ > struct i915_ggtt *ggtt = i915_vm_to_ggtt(vm); > struct sgt_iter sgt_iter; > gen6_pte_t __iomem *gtt_entries; > - gen6_pte_t gtt_entry; > + gen6_pte_t gtt_entry = I915_NULL_PTE; > dma_addr_t addr; > int rpm_atomic_seq; > int i = 0; > @@ -2453,14 +2455,17 @@ > iowrite32(gtt_entry, >t_entries[i++]); > } > > - /* XXX: This serves as a posting read to make sure that the PTE has > + /* > + * XXX: This serves as a posting read to make sure that the PTE has > * actually been updated. There is some concern that even though > * registers and PTEs are within the same BAR that they are potentially > * of NUMA access patterns. Therefore, even with the way we assume > * hardware should work, we must keep this posting read for paranoia. > */ > - if (i != 0) > + if (i != 0) { > + gen8_pte_t last_gtt_entry = readl(>t_entries[i-1]); > WARN_ON(readl(>t_entries[i-1]) != gtt_entry); > + } > > /* This next bit makes the above posting read even more important. We > * want to flush the TLBs only after we're certain all the PTE updates > diff -uNr a/linux/drivers/gpu/drm/i915/i915_gem_gtt.h b/linux/drivers/gpu/drm/i915/i915_gem_gtt.h > --- a/linux/drivers/gpu/drm/i915/i915_gem_gtt.h 2017-01-17 18:18:56.564887392 +0530 > +++ b/linux/drivers/gpu/drm/i915/i915_gem_gtt.h 2017-01-17 19:19:57.196980002 +0530 > @@ -54,6 +54,7 @@ > #define GEN6_PTE_UNCACHED (1 << 1) > #define GEN6_PTE_VALID (1 << 0) > > +#define I915_NULL_PTE 0 > #define I915_PTES(pte_len) (PAGE_SIZE / (pte_len)) > #define I915_PTE_MASK(pte_len) (I915_PTES(pte_len) - 1) > #define I915_PDES 512 -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: drm/i915: avoid "may be used uninitialized" warnings Date: Wed, 18 Jan 2017 10:31:09 +0200 Message-ID: <87bmv44vn6.fsf@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sreedhar Donelli , daniel.vetter@intel.com, linux-kernel@vger.kernel.org Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAxOCBKYW4gMjAxNywgU3JlZWRoYXIgRG9uZWxsaSA8c3JlZWRoYXIuZG9uZWxsaUB0 Y3MuY29tPiB3cm90ZToKPiBjb21waWxhdGlvbiBpc3N1ZSBvbiBrZXJuZWwtNC4xMC1yYzQgaXMg cmVzb2x2ZWQgYW5kIGkgY3JlYXRlZCBhIHBhdGNoIGZpbGUuCj4gcGxlYXNlIGZpbmQgdGhlIGF0 dGFjaG1lbnQgZm9yIHBhdGNoIGZpbGUuCgpUaGVyZSBhcmUgc2V2ZXJhbCBpc3N1ZXMgd2l0aCB0 aGlzIGNvbnRyaWJ1dGlvbi4gUGxlYXNlIGxlYXJuIHRvIHVzZSBnaXQKc2VuZC1lbWFpbCB0byBz ZW5kIHlvdXIgcGF0Y2hlcy4gRG9uJ3QgYXR0YWNoIHRoZW0uIFlvdSBuZWVkIHRvIHdyaXRlIGEK cHJvcGVyIGNvbW1pdCBtZXNzYWdlLiBUaGF0IGNvbW1pdCBtZXNzYWdlIG5lZWRzIHRvIGluY2x1 ZGUgYQpTaWduZWQtb2ZmLWJ5IHRhZy4gWW91IGFic29sdXRlbHkgY2FuJ3QgaGF2ZSBhIGRpc2Ns YWltZXIgYWJvdXQKY29uZmlkZW50aWFsL3ByaXZpbGVnZWQgd2l0aCB0aGUgcGF0Y2guIFNlZQpE b2N1bWVudGF0aW9uL3Byb2Nlc3Mvc3VibWl0dGluZy1wYXRjaGVzLnJzdC4KCk9uIHRoZSBjb250 ZW50LCB0aGVyZSBhcmUgbm8gaXNzdWVzIGluIHRoZSBjb2RlLCB0aGUgY29tcGlsZXIganVzdCBz ZWVtcwp1bmFibGUgdG8gZmlndXJlIGl0IG91dC4gSWYgd2Ugd2VyZSB0byAiZml4IiB0aGlzLCBm b3Igc3VyZSB3ZSBkb24ndApuZWVkIHRoZSBzdXBlcmZsdW91cyBjaGFuZ2VzIGluY2x1ZGVkIGlu IHRoaXMgcGF0Y2guCgpCUiwKSmFuaS4KCj4KPiBJIGhhdmUgdGFrZW4gdGhpcyBpc3N1ZSBmcm9t IGJlbG93IGxpbmsKPgo+IGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE3LzEvMTYvODkKPgo+Cj4K PiBUaGFua3MgJiBSZWdhcmRzCj4gIFNyZWVkaGFyIERvbmVsbGkKPiAgVGF0YSBDb25zdWx0YW5j eSBTZXJ2aWNlcwo+ICBQaDotIMKgICs5MSA4MDE5MDM5Mzk5Cj4gIENlbGw6LSArOTEgODAxOTAz OTM5OQo+ICBNYWlsdG86IHNyZWVkaGFyLmRvbmVsbGlAdGNzLmNvbQo+ICBXZWJzaXRlOiBodHRw Oi8vd3d3LnRjcy5jb20KPiAgX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiAgRXhwZXJpZW5jZSBjZXJ0YWludHkuCUlUIFNlcnZpY2VzCj4gIAkJCUJ1c2luZXNz IFNvbHV0aW9ucwo+ICAJCQlDb25zdWx0aW5nCj4gIF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4gIAo+ID09PT09LS0tLS09PT09PS0tLS0tPT09PT0KPiBOb3Rp Y2U6IFRoZSBpbmZvcm1hdGlvbiBjb250YWluZWQgaW4gdGhpcyBlLW1haWwKPiBtZXNzYWdlIGFu ZC9vciBhdHRhY2htZW50cyB0byBpdCBtYXkgY29udGFpbiAKPiBjb25maWRlbnRpYWwgb3IgcHJp dmlsZWdlZCBpbmZvcm1hdGlvbi4gSWYgeW91IGFyZSAKPiBub3QgdGhlIGludGVuZGVkIHJlY2lw aWVudCwgYW55IGRpc3NlbWluYXRpb24sIHVzZSwgCj4gcmV2aWV3LCBkaXN0cmlidXRpb24sIHBy aW50aW5nIG9yIGNvcHlpbmcgb2YgdGhlIAo+IGluZm9ybWF0aW9uIGNvbnRhaW5lZCBpbiB0aGlz IGUtbWFpbCBtZXNzYWdlIAo+IGFuZC9vciBhdHRhY2htZW50cyB0byBpdCBhcmUgc3RyaWN0bHkg cHJvaGliaXRlZC4gSWYgCj4geW91IGhhdmUgcmVjZWl2ZWQgdGhpcyBjb21tdW5pY2F0aW9uIGlu IGVycm9yLCAKPiBwbGVhc2Ugbm90aWZ5IHVzIGJ5IHJlcGx5IGUtbWFpbCBvciB0ZWxlcGhvbmUg YW5kIAo+IGltbWVkaWF0ZWx5IGFuZCBwZXJtYW5lbnRseSBkZWxldGUgdGhlIG1lc3NhZ2UgCj4g YW5kIGFueSBhdHRhY2htZW50cy4gVGhhbmsgeW91Cj4KPgo+IGRpZmYgLXVOciBhL2xpbnV4L2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIGIvbGludXgvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiAtLS0gYS9saW51eC9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbV9ndHQuYwkyMDE3LTAxLTE3IDE4OjE4OjU2LjU2NDg4NzM5MiArMDUzMAo+ICsrKyBi L2xpbnV4L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCTIwMTctMDEtMTcgMTk6 MTg6NTAuNTI0OTc4MzE1ICswNTMwCj4gQEAgLTIzNjQsNyArMjM2NCw3IEBACj4gIAlzdHJ1Y3Qg aTkxNV9nZ3R0ICpnZ3R0ID0gaTkxNV92bV90b19nZ3R0KHZtKTsKPiAgCXN0cnVjdCBzZ3RfaXRl ciBzZ3RfaXRlcjsKPiAgCWdlbjhfcHRlX3QgX19pb21lbSAqZ3R0X2VudHJpZXM7Cj4gLQlnZW44 X3B0ZV90IGd0dF9lbnRyeTsKPiArCWdlbjhfcHRlX3QgZ3R0X2VudHJ5ID0gSTkxNV9OVUxMX1BU RTsKPiAgCWRtYV9hZGRyX3QgYWRkcjsKPiAgCWludCBycG1fYXRvbWljX3NlcTsKPiAgCWludCBp ID0gMDsKPiBAQCAtMjM4NSw4ICsyMzg1LDEwIEBACj4gIAkgKiBvZiBOVU1BIGFjY2VzcyBwYXR0 ZXJucy4gVGhlcmVmb3JlLCBldmVuIHdpdGggdGhlIHdheSB3ZSBhc3N1bWUKPiAgCSAqIGhhcmR3 YXJlIHNob3VsZCB3b3JrLCB3ZSBtdXN0IGtlZXAgdGhpcyBwb3N0aW5nIHJlYWQgZm9yIHBhcmFu b2lhLgo+ICAJICovCj4gLQlpZiAoaSAhPSAwKQo+ICsJaWYgKGkgIT0gMCl7Cj4gKwkJZ2VuOF9w dGVfdCBsYXN0X2d0dF9lbnRyeSA9IHJlYWRxKCZndHRfZW50cmllc1tpLTFdKTsKPiAgCQlXQVJO X09OKHJlYWRxKCZndHRfZW50cmllc1tpLTFdKSAhPSBndHRfZW50cnkpOwo+ICsJfQo+ICAKPiAg CS8qIFRoaXMgbmV4dCBiaXQgbWFrZXMgdGhlIGFib3ZlIHBvc3RpbmcgcmVhZCBldmVuIG1vcmUg aW1wb3J0YW50LiBXZQo+ICAJICogd2FudCB0byBmbHVzaCB0aGUgVExCcyBvbmx5IGFmdGVyIHdl J3JlIGNlcnRhaW4gYWxsIHRoZSBQVEUgdXBkYXRlcwo+IEBAIC0yNDM5LDcgKzI0NDEsNyBAQAo+ ICAJc3RydWN0IGk5MTVfZ2d0dCAqZ2d0dCA9IGk5MTVfdm1fdG9fZ2d0dCh2bSk7Cj4gIAlzdHJ1 Y3Qgc2d0X2l0ZXIgc2d0X2l0ZXI7Cj4gIAlnZW42X3B0ZV90IF9faW9tZW0gKmd0dF9lbnRyaWVz Owo+IC0JZ2VuNl9wdGVfdCBndHRfZW50cnk7Cj4gKwlnZW42X3B0ZV90IGd0dF9lbnRyeSA9IEk5 MTVfTlVMTF9QVEU7Cj4gIAlkbWFfYWRkcl90IGFkZHI7Cj4gIAlpbnQgcnBtX2F0b21pY19zZXE7 Cj4gIAlpbnQgaSA9IDA7Cj4gQEAgLTI0NTMsMTQgKzI0NTUsMTcgQEAKPiAgCQlpb3dyaXRlMzIo Z3R0X2VudHJ5LCAmZ3R0X2VudHJpZXNbaSsrXSk7Cj4gIAl9Cj4gIAo+IC0JLyogWFhYOiBUaGlz IHNlcnZlcyBhcyBhIHBvc3RpbmcgcmVhZCB0byBtYWtlIHN1cmUgdGhhdCB0aGUgUFRFIGhhcwo+ ICsJLyogCj4gKwkgKiBYWFg6IFRoaXMgc2VydmVzIGFzIGEgcG9zdGluZyByZWFkIHRvIG1ha2Ug c3VyZSB0aGF0IHRoZSBQVEUgaGFzCj4gIAkgKiBhY3R1YWxseSBiZWVuIHVwZGF0ZWQuIFRoZXJl IGlzIHNvbWUgY29uY2VybiB0aGF0IGV2ZW4gdGhvdWdoCj4gIAkgKiByZWdpc3RlcnMgYW5kIFBU RXMgYXJlIHdpdGhpbiB0aGUgc2FtZSBCQVIgdGhhdCB0aGV5IGFyZSBwb3RlbnRpYWxseQo+ICAJ ICogb2YgTlVNQSBhY2Nlc3MgcGF0dGVybnMuIFRoZXJlZm9yZSwgZXZlbiB3aXRoIHRoZSB3YXkg d2UgYXNzdW1lCj4gIAkgKiBoYXJkd2FyZSBzaG91bGQgd29yaywgd2UgbXVzdCBrZWVwIHRoaXMg cG9zdGluZyByZWFkIGZvciBwYXJhbm9pYS4KPiAgCSAqLwo+IC0JaWYgKGkgIT0gMCkKPiArCWlm IChpICE9IDApIHsKPiArCQlnZW44X3B0ZV90IGxhc3RfZ3R0X2VudHJ5ID0gcmVhZGwoJmd0dF9l bnRyaWVzW2ktMV0pOwo+ICAJCVdBUk5fT04ocmVhZGwoJmd0dF9lbnRyaWVzW2ktMV0pICE9IGd0 dF9lbnRyeSk7Cj4gKwl9Cj4gIAo+ICAJLyogVGhpcyBuZXh0IGJpdCBtYWtlcyB0aGUgYWJvdmUg cG9zdGluZyByZWFkIGV2ZW4gbW9yZSBpbXBvcnRhbnQuIFdlCj4gIAkgKiB3YW50IHRvIGZsdXNo IHRoZSBUTEJzIG9ubHkgYWZ0ZXIgd2UncmUgY2VydGFpbiBhbGwgdGhlIFBURSB1cGRhdGVzCj4g ZGlmZiAtdU5yIGEvbGludXgvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmggYi9s aW51eC9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuaAo+IC0tLSBhL2xpbnV4L2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5oCTIwMTctMDEtMTcgMTg6MTg6NTYuNTY0 ODg3MzkyICswNTMwCj4gKysrIGIvbGludXgvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1f Z3R0LmgJMjAxNy0wMS0xNyAxOToxOTo1Ny4xOTY5ODAwMDIgKzA1MzAKPiBAQCAtNTQsNiArNTQs NyBAQAo+ICAjZGVmaW5lIEdFTjZfUFRFX1VOQ0FDSEVECQkoMSA8PCAxKQo+ICAjZGVmaW5lIEdF TjZfUFRFX1ZBTElECQkJKDEgPDwgMCkKPiAgCj4gKyNkZWZpbmUJSTkxNV9OVUxMX1BURQkJCTAK PiAgI2RlZmluZSBJOTE1X1BURVMocHRlX2xlbikJCShQQUdFX1NJWkUgLyAocHRlX2xlbikpCj4g ICNkZWZpbmUgSTkxNV9QVEVfTUFTSyhwdGVfbGVuKQkJKEk5MTVfUFRFUyhwdGVfbGVuKSAtIDEp Cj4gICNkZWZpbmUgSTkxNV9QREVTCQkJNTEyCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4g U291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=