From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49960)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1c7MjK-0004fZ-SB
	for qemu-devel@nongnu.org; Thu, 17 Nov 2016 08:27:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1c7MjJ-0000W7-Tx
	for qemu-devel@nongnu.org; Thu, 17 Nov 2016 08:27:54 -0500
From: Markus Armbruster <armbru@redhat.com>
In-Reply-To: <1479385863-7648-1-git-send-email-ann.zhuangyanying@huawei.com>
	(Zhuangyanying's message of "Thu, 17 Nov 2016 20:31:03 +0800")
References: <1479385863-7648-1-git-send-email-ann.zhuangyanying@huawei.com>
Date: Thu, 17 Nov 2016 14:27:50 +0100
Message-ID: <87bmxegrs9.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3] ivshmem: Fix 64 bit memory bar
 configuration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhuangyanying <ann.zhuangyanying@huawei.com>
Cc: marcandre.lureau@redhat.com, pbonzini@redhat.com, mst@redhat.com, arei.gonglei@huawei.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org

Zhuangyanying <ann.zhuangyanying@huawei.com> writes:

> From: Zhuang Yanying <ann.zhuangyanying@huawei.com>
>
>     Device ivshmem property use64=3D0 is designed to make the device
>     expose a 32 bit shared memory BAR instead of 64 bit one.  The
>     default is a 64 bit BAR, except pc-1.2 and older retain a 32 bit
>     BAR.  A 32 bit BAR can support only up to 1 GiB of shared memory.
>
>     This worked as designed until commit 5400c02 accidentally flipped
>     its sense: since then, we misinterpret use64=3D0 as use64=3D1 and vice
>     versa.  Worse, the default got flipped as well.  Devices
>     ivshmem-plain and ivshmem-doorbell are not affected.
>
>     Fix by restoring the test of IVShmemState member not_legacy_32bit
>     that got messed up in commit 5400c02.  Also update its
>     initialization for devices ivhsmem-plain and ivshmem-doorbell.
>     Without that, they'd regress to 32 bit BARs.
>
>     Cc: qemu-stable@nongnu.org
>     Signed-off-by: Zhuang Yanying <ann.zhuangyanying@huawei.com>
>     Reviewed-by: Gonglei <arei.gonglei@huawei.com>
>     Reviewed-by: Marc-Andr. Lureau <marcandre.lureau@redhat.com>

Commit message should not be indented, and Marc-Andr=C3=A9's name got
mangled.  Both could be touched up on commit.

Thanks again for cleaning up my mess.

Reviewed-by: Markus Armbruster <armbru@redhat.com>