From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcGw4-0007EH-O9 for qemu-devel@nongnu.org; Tue, 23 Aug 2016 15:00:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bcGvy-0000Jg-Ou for qemu-devel@nongnu.org; Tue, 23 Aug 2016 15:00:31 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bcGvy-0000Io-G5 for qemu-devel@nongnu.org; Tue, 23 Aug 2016 15:00:26 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7NIxIre068602 for ; Tue, 23 Aug 2016 15:00:25 -0400 Received: from e06smtp09.uk.ibm.com (e06smtp09.uk.ibm.com [195.75.94.105]) by mx0a-001b2d01.pphosted.com with ESMTP id 250q1ktk8x-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 23 Aug 2016 15:00:25 -0400 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Aug 2016 20:00:22 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 98C921B0804B for ; Tue, 23 Aug 2016 20:01:58 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u7NJ0JUf21168216 for ; Tue, 23 Aug 2016 19:00:19 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u7NJ0JBF014473 for ; Tue, 23 Aug 2016 13:00:19 -0600 From: Sascha Silbe In-Reply-To: <1471975876-23385-1-git-send-email-sw@weilnetz.de> References: <1471975876-23385-1-git-send-email-sw@weilnetz.de> Date: Tue, 23 Aug 2016 21:00:19 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-Id: <87bn0jjoos.fsf@oc4731375738.ibm.com> Subject: Re: [Qemu-devel] [PATCH for-2.7] wxx: Fix broken build (mkdtemp unavailable) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , QEMU Developer Cc: Peter Maydell Dear Stefan, Stefan Weil writes: > Commit 50455700092412d90ffaf57ee5d00f38f7d1cc5b added new code which > does not compile for Windows. [...] [include/glib-compat.h] > @@ -48,6 +48,7 @@ static inline gint64 qemu_g_get_monotonic_time(void) > gint g_poll_fixed(GPollFD *fds, guint nfds, gint timeout); > #endif > > +#if !defined(_WIN32) > #if !GLIB_CHECK_VERSION(2, 30, 0) > /* Not a 100% compatible implementation, but good enough for most > * cases. Placeholders are only supported at the end of the > @@ -65,8 +66,10 @@ static inline gchar *qemu_g_dir_make_tmp(gchar const *= tmpl, GError **error) > g_free(path); > return NULL; > } > + > #define g_dir_make_tmp(tmpl, error) qemu_g_dir_make_tmp(tmpl, error) > #endif /* glib 2.30 */ > +#endif /* !_WIN32 */ This worked fine in my cross-build environment (mingw32-* on Fedora 22) as that has glib 2.44.0. Is there a specific reason you're using a glib version that's at least half a decade old (glib 2.30.0 was released in 2011) on Windows? AFAICT the MSYS2 installer recommended by glib upstream [1] has glib 2.41.1. As for your change: It may fix building qemu itself, but building test-logging should still be broken. Unlike some other tests, it isn't built on POSIX or Linux only. Did "make check" work before my patch in your environment? Sascha [1] http://www.gtk.org/download/windows.php [2] https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-glib2/PKG= BUILD --=20 Softwareentwicklung Sascha Silbe, Niederhofenstra=C3=9Fe 5/1, 71229 Leonberg https://se-silbe.de/ USt-IdNr. DE281696641