From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKTyl-0005TC-HQ for qemu-devel@nongnu.org; Tue, 05 Jul 2016 13:17:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKTyg-0004eI-BB for qemu-devel@nongnu.org; Tue, 05 Jul 2016 13:17:46 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:63047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKTyg-0004e1-2r for qemu-devel@nongnu.org; Tue, 05 Jul 2016 13:17:42 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u65H95tF095484 for ; Tue, 5 Jul 2016 13:17:39 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 23x9s39rn5-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 05 Jul 2016 13:17:39 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Jul 2016 18:17:35 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id D30012190046 for ; Tue, 5 Jul 2016 18:17:00 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u65HHVw621692834 for ; Tue, 5 Jul 2016 17:17:31 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u65HHVi3025667 for ; Tue, 5 Jul 2016 11:17:31 -0600 From: Sascha Silbe In-Reply-To: <1467291213-13393-2-git-send-email-armbru@redhat.com> References: <1467291213-13393-1-git-send-email-armbru@redhat.com> <1467291213-13393-2-git-send-email-armbru@redhat.com> Date: Tue, 05 Jul 2016 19:17:31 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-Id: <87bn2cknro.fsf@oc4731375738.ibm.com> Subject: Re: [Qemu-devel] [PATCH RFC v3 1/5] tests: New make target check-source List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, pbonzini@redhat.com, Cornelia Huck Dear Markus, I looked into the s390x specific failures as it would be nice to get them fixed up right away. Fortunately it looks like all of them are related to known shortcomings of the header check rather than actual issues with the header files, so there's nothing for me to do. ;) Markus Armbruster writes: [...] > Some headers fail the test because they need to be compiled with > -DNEED_CPU_H, and testing them is not yet implemented. They are > marked with a comment > > /* NOTE: May only be included into target-dependent code */ The following header files either include target-s390x/cpu.h themselves or expect it to have been included already so they should be marked with the above note rather than the FIXME: - hw/s390x/ipl.h - hw/s390x/s390-pci-inst.h - hw/s390x/s390-virtio.h [linux-headers/asm-s390/kvm.h] > +/* FIXME Does not pass make check-headers with CONFIG_WIN32, yet! */ Is this because of the linux/types.h include or is there some other issue? Should we even check these imported headers? [linux-user/host/*/hostdep.h] > +/* FIXME Does not pass make check-headers, yet! */ The "struct ucontext" definition used by hostdep.h differs between host architectures. Not sure if testing the headers for "foreign" host architectures is possible; we should probably just skip them instead of marking them with a FIXME. Many or even most other non-softmmu target failures smell like NEED_CPU_H. [*/helper.h] > +/* FIXME Does not pass make check-headers, yet! */ Probably never will. Looks like it's meant to be included only by some magic preprocessor code. Sascha --=20 Softwareentwicklung Sascha Silbe, Niederhofenstra=C3=9Fe 5/1, 71229 Leonberg https://se-silbe.de/ USt-IdNr. DE281696641