From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56046)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bDa0v-0005IW-FV
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 12:19:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bDa0s-0001w2-8X
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 12:19:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44224)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bDa0s-0001vm-2c
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 12:19:26 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id B0BAA63303
	for <qemu-devel@nongnu.org>; Thu, 16 Jun 2016 16:19:25 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <1465526889-8339-1-git-send-email-eblake@redhat.com>
	<1465526889-8339-2-git-send-email-eblake@redhat.com>
Date: Thu, 16 Jun 2016 18:19:23 +0200
In-Reply-To: <1465526889-8339-2-git-send-email-eblake@redhat.com> (Eric
	Blake's message of "Thu, 9 Jun 2016 20:48:06 -0600")
Message-ID: <87bn31w1h0.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 1/4] qobject: Correct JSON lexer grammar
 comments
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

Eric Blake <eblake@redhat.com> writes:

> Fix the regex comments describing what we parse as JSON.  No change
> to the lexer itself, just to the comments:
> - The "" and '' string construction was missing alternation between
> different escape sequences
> - The construction for numbers forgot to handle optional leading '-'
> - The construction for numbers was grouped incorrectly so that it
> didn't permit '0.1'
> - The construction for numbers forgot to mark the exponent as optional
> - No mention that our '' string and "\'" are JSON extensions
> - No mention of our %d and related extensions when constructing JSON
>
> Signed-off-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>

I'll take this one through qapi-next.  Thanks!