All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug
@ 2016-05-09 12:00 William Wu
  2016-05-09 12:04 ` Greg KH
  2016-05-09 12:10 ` Felipe Balbi
  0 siblings, 2 replies; 9+ messages in thread
From: William Wu @ 2016-05-09 12:00 UTC (permalink / raw)
  To: gregkh, balbi, heiko
  Cc: briannorris, dianders, kever.yang, huangtao, frank.wang,
	eddie.cai, John.Youn, linux-kernel, linux-usb, William Wu

Signed-off-by: William Wu <william.wu@rock-chips.com>
---
 drivers/usb/dwc3/core.h    | 1 +
 drivers/usb/dwc3/debugfs.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index e15e307..f268869 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -86,6 +86,7 @@
 #define DWC3_GCTL		0xc110
 #define DWC3_GEVTEN		0xc114
 #define DWC3_GSTS		0xc118
+#define DWC3_GUCTL1		0xc11c
 #define DWC3_GSNPSID		0xc120
 #define DWC3_GGPIO		0xc124
 #define DWC3_GUID		0xc128
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
index b1dd3c6..f3c9f44 100644
--- a/drivers/usb/dwc3/debugfs.c
+++ b/drivers/usb/dwc3/debugfs.c
@@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
 	dump_register(GCTL),
 	dump_register(GEVTEN),
 	dump_register(GSTS),
+	dump_register(GUCTL1),
 	dump_register(GSNPSID),
 	dump_register(GGPIO),
 	dump_register(GUID),
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug
  2016-05-09 12:00 [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug William Wu
@ 2016-05-09 12:04 ` Greg KH
  2016-05-09 12:10 ` Felipe Balbi
  1 sibling, 0 replies; 9+ messages in thread
From: Greg KH @ 2016-05-09 12:04 UTC (permalink / raw)
  To: William Wu
  Cc: balbi, heiko, briannorris, dianders, kever.yang, huangtao,
	frank.wang, eddie.cai, John.Youn, linux-kernel, linux-usb

On Mon, May 09, 2016 at 08:00:05PM +0800, William Wu wrote:
> Signed-off-by: William Wu <william.wu@rock-chips.com>

We can't take patches with no changelog text at all, sorry.

Please explain why you are doing what you are doing in the changelog
text.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug
  2016-05-09 12:00 [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug William Wu
  2016-05-09 12:04 ` Greg KH
@ 2016-05-09 12:10 ` Felipe Balbi
  2016-05-09 13:16   ` William Wu
  1 sibling, 1 reply; 9+ messages in thread
From: Felipe Balbi @ 2016-05-09 12:10 UTC (permalink / raw)
  To: William Wu, gregkh, heiko
  Cc: briannorris, dianders, kever.yang, huangtao, frank.wang,
	eddie.cai, John.Youn, linux-kernel, linux-usb, William Wu

[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]

William Wu <william.wu@rock-chips.com> writes:

> Signed-off-by: William Wu <william.wu@rock-chips.com>

no changelog = no commit, sorry. Why do you want to dump GUCTL1?

> ---
>  drivers/usb/dwc3/core.h    | 1 +
>  drivers/usb/dwc3/debugfs.c | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index e15e307..f268869 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -86,6 +86,7 @@
>  #define DWC3_GCTL		0xc110
>  #define DWC3_GEVTEN		0xc114
>  #define DWC3_GSTS		0xc118
> +#define DWC3_GUCTL1		0xc11c
>  #define DWC3_GSNPSID		0xc120
>  #define DWC3_GGPIO		0xc124
>  #define DWC3_GUID		0xc128
> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> index b1dd3c6..f3c9f44 100644
> --- a/drivers/usb/dwc3/debugfs.c
> +++ b/drivers/usb/dwc3/debugfs.c
> @@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
>  	dump_register(GCTL),
>  	dump_register(GEVTEN),
>  	dump_register(GSTS),
> +	dump_register(GUCTL1),
>  	dump_register(GSNPSID),
>  	dump_register(GGPIO),
>  	dump_register(GUID),
> -- 
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug
  2016-05-09 12:10 ` Felipe Balbi
@ 2016-05-09 13:16   ` William Wu
  2016-05-09 13:35     ` Felipe Balbi
  0 siblings, 1 reply; 9+ messages in thread
From: William Wu @ 2016-05-09 13:16 UTC (permalink / raw)
  To: Felipe Balbi, gregkh, heiko
  Cc: briannorris, dianders, kever.yang, huangtao, frank.wang,
	eddie.cai, John.Youn, linux-kernel, linux-usb

On 05/09/2016 08:10 PM, Felipe Balbi wrote:
> William Wu <william.wu@rock-chips.com> writes:
     Thanks Felipe Balbi and Greg KH. I'm really sorry that I forgot to 
add changelog.
>> Signed-off-by: William Wu <william.wu@rock-chips.com>
> no changelog = no commit, sorry. Why do you want to dump GUCTL1?
     Because GUCTL1 can be written by user. For rockchip platform,
     we set GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK(bit26) to 1 in 
bootrom(used for usb2.0 device only),
     and after kernel boot, I want to check whether this bit can be 
reset to default 0 after core reset.
     Dump GUCTL1 reg from debugfs is more convenient for me.
>
>> ---
>>   drivers/usb/dwc3/core.h    | 1 +
>>   drivers/usb/dwc3/debugfs.c | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index e15e307..f268869 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -86,6 +86,7 @@
>>   #define DWC3_GCTL		0xc110
>>   #define DWC3_GEVTEN		0xc114
>>   #define DWC3_GSTS		0xc118
>> +#define DWC3_GUCTL1		0xc11c
>>   #define DWC3_GSNPSID		0xc120
>>   #define DWC3_GGPIO		0xc124
>>   #define DWC3_GUID		0xc128
>> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
>> index b1dd3c6..f3c9f44 100644
>> --- a/drivers/usb/dwc3/debugfs.c
>> +++ b/drivers/usb/dwc3/debugfs.c
>> @@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
>>   	dump_register(GCTL),
>>   	dump_register(GEVTEN),
>>   	dump_register(GSTS),
>> +	dump_register(GUCTL1),
>>   	dump_register(GSNPSID),
>>   	dump_register(GGPIO),
>>   	dump_register(GUID),
>> -- 
>> 1.9.1
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug
  2016-05-09 13:16   ` William Wu
@ 2016-05-09 13:35     ` Felipe Balbi
  0 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2016-05-09 13:35 UTC (permalink / raw)
  To: William Wu, gregkh, heiko
  Cc: briannorris, dianders, kever.yang, huangtao, frank.wang,
	eddie.cai, John.Youn, linux-kernel, linux-usb

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

William Wu <william.wu@rock-chips.com> writes:
> On 05/09/2016 08:10 PM, Felipe Balbi wrote:
>> William Wu <william.wu@rock-chips.com> writes:
>      Thanks Felipe Balbi and Greg KH. I'm really sorry that I forgot to 
> add changelog.
>>> Signed-off-by: William Wu <william.wu@rock-chips.com>
>> no changelog = no commit, sorry. Why do you want to dump GUCTL1?
>      Because GUCTL1 can be written by user. For rockchip platform,
>      we set GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK(bit26) to 1 in 
> bootrom(used for usb2.0 device only),
>      and after kernel boot, I want to check whether this bit can be 
> reset to default 0 after core reset.
>      Dump GUCTL1 reg from debugfs is more convenient for me.

cool, something like this could go to commit log :-)

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug
@ 2016-05-13 10:07   ` William Wu
  0 siblings, 0 replies; 9+ messages in thread
From: William Wu @ 2016-05-13 10:07 UTC (permalink / raw)
  To: gregkh, balbi, heiko
  Cc: linux-rockchip, briannorris, dianders, kever.yang, huangtao,
	frank.wang, eddie.cai, John.Youn, linux-kernel, linux-usb

On 05/13/2016 06:05 PM, William Wu wrote:
> GUCTL1 reg has some useful functions which can be
> written by user. For rockchip platform, we set
> GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK (bit26, applicable
> for the core is programmed to operate in 2.0 device
> only) to 1 in bootrom, and after start the kernel,
> we want to check whether this bit can be reset to
> default 0 after the core reset. Dump GUCTL1 reg from
> debugfs is more convenient for us.
>
> Signed-off-by: William Wu <william.wu@rock-chips.com>
> ---
> Changes in v2:
> - add commit log
>
>   drivers/usb/dwc3/core.h    | 1 +
>   drivers/usb/dwc3/debugfs.c | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index abed84f..c4758d5 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -86,6 +86,7 @@
>   #define DWC3_GCTL		0xc110
>   #define DWC3_GEVTEN		0xc114
>   #define DWC3_GSTS		0xc118
> +#define DWC3_GUCTL1		0xc11c
>   #define DWC3_GSNPSID		0xc120
>   #define DWC3_GGPIO		0xc124
>   #define DWC3_GUID		0xc128
> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> index b1dd3c6..f3c9f44 100644
> --- a/drivers/usb/dwc3/debugfs.c
> +++ b/drivers/usb/dwc3/debugfs.c
> @@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
>   	dump_register(GCTL),
>   	dump_register(GEVTEN),
>   	dump_register(GSTS),
> +	dump_register(GUCTL1),
>   	dump_register(GSNPSID),
>   	dump_register(GGPIO),
>   	dump_register(GUID),
I'm sorry for forgot to add v2 in commit. I'll resend it later.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug
@ 2016-05-13 10:07   ` William Wu
  0 siblings, 0 replies; 9+ messages in thread
From: William Wu @ 2016-05-13 10:07 UTC (permalink / raw)
  To: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
	balbi-DgEjT+Ai2ygdnm+yROfE0A, heiko-4mtYJXux2i+zQB+pC5nmwQ
  Cc: huangtao-TNX95d0MmH7DzftRWevZcw,
	frank.wang-TNX95d0MmH7DzftRWevZcw,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA,
	kever.yang-TNX95d0MmH7DzftRWevZcw,
	dianders-hpIqsD4AKlfQT0dZR+AlfA,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	eddie.cai-TNX95d0MmH7DzftRWevZcw,
	briannorris-hpIqsD4AKlfQT0dZR+AlfA,
	John.Youn-HKixBCOQz3hWk0Htik3J/w

On 05/13/2016 06:05 PM, William Wu wrote:
> GUCTL1 reg has some useful functions which can be
> written by user. For rockchip platform, we set
> GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK (bit26, applicable
> for the core is programmed to operate in 2.0 device
> only) to 1 in bootrom, and after start the kernel,
> we want to check whether this bit can be reset to
> default 0 after the core reset. Dump GUCTL1 reg from
> debugfs is more convenient for us.
>
> Signed-off-by: William Wu <william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
> Changes in v2:
> - add commit log
>
>   drivers/usb/dwc3/core.h    | 1 +
>   drivers/usb/dwc3/debugfs.c | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index abed84f..c4758d5 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -86,6 +86,7 @@
>   #define DWC3_GCTL		0xc110
>   #define DWC3_GEVTEN		0xc114
>   #define DWC3_GSTS		0xc118
> +#define DWC3_GUCTL1		0xc11c
>   #define DWC3_GSNPSID		0xc120
>   #define DWC3_GGPIO		0xc124
>   #define DWC3_GUID		0xc128
> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> index b1dd3c6..f3c9f44 100644
> --- a/drivers/usb/dwc3/debugfs.c
> +++ b/drivers/usb/dwc3/debugfs.c
> @@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
>   	dump_register(GCTL),
>   	dump_register(GEVTEN),
>   	dump_register(GSTS),
> +	dump_register(GUCTL1),
>   	dump_register(GSNPSID),
>   	dump_register(GGPIO),
>   	dump_register(GUID),
I'm sorry for forgot to add v2 in commit. I'll resend it later.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug
@ 2016-05-13 10:05 ` William Wu
  0 siblings, 0 replies; 9+ messages in thread
From: William Wu @ 2016-05-13 10:05 UTC (permalink / raw)
  To: gregkh, balbi, heiko
  Cc: linux-rockchip, briannorris, dianders, kever.yang, huangtao,
	frank.wang, eddie.cai, John.Youn, linux-kernel, linux-usb,
	William Wu

GUCTL1 reg has some useful functions which can be
written by user. For rockchip platform, we set
GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK (bit26, applicable
for the core is programmed to operate in 2.0 device
only) to 1 in bootrom, and after start the kernel,
we want to check whether this bit can be reset to
default 0 after the core reset. Dump GUCTL1 reg from
debugfs is more convenient for us.

Signed-off-by: William Wu <william.wu@rock-chips.com>
---
Changes in v2:
- add commit log

 drivers/usb/dwc3/core.h    | 1 +
 drivers/usb/dwc3/debugfs.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index abed84f..c4758d5 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -86,6 +86,7 @@
 #define DWC3_GCTL		0xc110
 #define DWC3_GEVTEN		0xc114
 #define DWC3_GSTS		0xc118
+#define DWC3_GUCTL1		0xc11c
 #define DWC3_GSNPSID		0xc120
 #define DWC3_GGPIO		0xc124
 #define DWC3_GUID		0xc128
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
index b1dd3c6..f3c9f44 100644
--- a/drivers/usb/dwc3/debugfs.c
+++ b/drivers/usb/dwc3/debugfs.c
@@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
 	dump_register(GCTL),
 	dump_register(GEVTEN),
 	dump_register(GSTS),
+	dump_register(GUCTL1),
 	dump_register(GSNPSID),
 	dump_register(GGPIO),
 	dump_register(GUID),
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug
@ 2016-05-13 10:05 ` William Wu
  0 siblings, 0 replies; 9+ messages in thread
From: William Wu @ 2016-05-13 10:05 UTC (permalink / raw)
  To: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
	balbi-DgEjT+Ai2ygdnm+yROfE0A, heiko-4mtYJXux2i+zQB+pC5nmwQ
  Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	briannorris-hpIqsD4AKlfQT0dZR+AlfA,
	dianders-hpIqsD4AKlfQT0dZR+AlfA,
	kever.yang-TNX95d0MmH7DzftRWevZcw,
	huangtao-TNX95d0MmH7DzftRWevZcw,
	frank.wang-TNX95d0MmH7DzftRWevZcw,
	eddie.cai-TNX95d0MmH7DzftRWevZcw,
	John.Youn-HKixBCOQz3hWk0Htik3J/w,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA, William Wu

GUCTL1 reg has some useful functions which can be
written by user. For rockchip platform, we set
GUCTL1.DEV_FORCE_20_CLK_FOR_30_CLK (bit26, applicable
for the core is programmed to operate in 2.0 device
only) to 1 in bootrom, and after start the kernel,
we want to check whether this bit can be reset to
default 0 after the core reset. Dump GUCTL1 reg from
debugfs is more convenient for us.

Signed-off-by: William Wu <william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
---
Changes in v2:
- add commit log

 drivers/usb/dwc3/core.h    | 1 +
 drivers/usb/dwc3/debugfs.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index abed84f..c4758d5 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -86,6 +86,7 @@
 #define DWC3_GCTL		0xc110
 #define DWC3_GEVTEN		0xc114
 #define DWC3_GSTS		0xc118
+#define DWC3_GUCTL1		0xc11c
 #define DWC3_GSNPSID		0xc120
 #define DWC3_GGPIO		0xc124
 #define DWC3_GUID		0xc128
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
index b1dd3c6..f3c9f44 100644
--- a/drivers/usb/dwc3/debugfs.c
+++ b/drivers/usb/dwc3/debugfs.c
@@ -47,6 +47,7 @@ static const struct debugfs_reg32 dwc3_regs[] = {
 	dump_register(GCTL),
 	dump_register(GEVTEN),
 	dump_register(GSTS),
+	dump_register(GUCTL1),
 	dump_register(GSNPSID),
 	dump_register(GGPIO),
 	dump_register(GUID),
-- 
1.9.1


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-05-13 10:10 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-09 12:00 [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug William Wu
2016-05-09 12:04 ` Greg KH
2016-05-09 12:10 ` Felipe Balbi
2016-05-09 13:16   ` William Wu
2016-05-09 13:35     ` Felipe Balbi
2016-05-13 10:05 William Wu
2016-05-13 10:05 ` William Wu
2016-05-13 10:07 ` William Wu
2016-05-13 10:07   ` William Wu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.