From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52633)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aSpmu-0007ZO-IT
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 12:39:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aSpmq-0007Za-Ea
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 12:39:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33497)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aSpmq-0007ZV-9k
	for qemu-devel@nongnu.org; Mon, 08 Feb 2016 12:39:44 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1454945806-14090-1-git-send-email-eblake@redhat.com>
Date: Mon, 08 Feb 2016 18:39:40 +0100
In-Reply-To: <1454945806-14090-1-git-send-email-eblake@redhat.com> (Eric
	Blake's message of "Mon, 8 Feb 2016 08:36:46 -0700")
Message-ID: <87bn7rrtib.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>

Eric Blake <eblake@redhat.com> writes:

> As a followup to commit cbf2115, clean up the includes in files
> generated by QAPI so that osdep.h is included first in .c files,
> and headers which it implies are not included manually.  This
> patch is done manually, since Coccinelle (and therefore
> scripts/clean-includes) doesn't see into the generator scripts.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>

  CC    tests/check-qfloat.o
In file included from /home/armbru/work/qemu/include/qapi/qmp/qobject.h:37:=
0,
                 from /home/armbru/work/qemu/include/qapi/qmp/qfloat.h:18,
                 from /home/armbru/work/qemu/tests/check-qfloat.c:15:
./qapi-types.h:55:9: error: unknown type name =E2=80=98bool=E2=80=99
         bool value;
         ^

Chicken and egg problem?  check-qfloat.c doesn't include osdep.h, yet...