From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932476AbbLHBQ2 (ORCPT ); Mon, 7 Dec 2015 20:16:28 -0500 Received: from gabe.freedesktop.org ([131.252.210.177]:58162 "EHLO gabe.freedesktop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932146AbbLHBQ1 (ORCPT ); Mon, 7 Dec 2015 20:16:27 -0500 From: Eric Anholt To: Emil Velikov Cc: ML dri-devel , "Linux-Kernel\@Vger. Kernel. Org" Subject: Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls. In-Reply-To: References: <1449002158-19156-1-git-send-email-eric@anholt.net> <1449002158-19156-3-git-send-email-eric@anholt.net> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 07 Dec 2015 17:16:23 -0800 Message-ID: <87bna1d9js.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Emil Velikov writes: > Hi Eric, > > A couple of suggestions/requests on the UAPI header side > > On 1 December 2015 at 20:35, Eric Anholt wrote: > >> --- /dev/null >> +++ b/include/uapi/drm/vc4_drm.h > >> +#include >> + > Can we make this a "drm.h" ? Nope. include/uapi/drm/vc4_drm.h:27:17: fatal error: drm.h: No such file or directory and none of the drivers do, either. >> +struct drm_vc4_create_bo { >> + uint32_t size; >> + uint32_t flags; >> + /** Returned GEM handle for the BO. */ >> + uint32_t handle; >> + uint32_t pad; > ... and not use the stdint.h types but __{s,u}* through the file. > > I'd rather than not nag why we want/need those, but if you prefer I > can repeat myself/others. I've switched to using the special types. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJWZi9nAAoJELXWKTbR/J7oIigP/iqFpvIHHNbjrRpbcPmPhJ3b EWgPVpGL4e7qa4zXMIPYDYglaWfCA3EXO9CKy/TQ+CgQOEvOnJb7x8kl9iK3+QyJ ZBu5/03ztp+9usCbKZ6EIaN9ZIFf4U4OEanxzL+BGJqTDg1NCou4FuifukY8ypid RNg0KRWng7GzyBBIBiIm69ax133q/CnnF6S3nXGzuqZLzw18lMbUwSYnSDcib1jk vBxiKxafqe5mvY16/0gmjsvH7UoWb+1kIveRPaRKgp6CQXQbvDFTN+JZaCuAEGmx t+HYBySnaroRCrM1yxAbedJPOtZP0Zo73MCxY7j85I6qiNLvmULqtwzRMB+vF4qi pKuCqVU1T7UxZIafZ8bGnuEZ7bbFEmS8M8exA6VwxgUAcs4DuYdGnshuLQ+9G7XL YbAXYLKnuoJcbknVMmRT+aVeW2wU4/DdkG+DvCuvA2mO5tycWFkn6Ga+A7Ys0Z8f K/vDOOH8FMRGnaDA0EkXREHaSD3bvuKLC1t+hD7z3KkYPt6yicTDQD4q+GhYxxq/ wlIsRblw7TQy+tAwJdRzvbv/ssy4ZKeAGmrs23dTe6sqXUbh/UV7QjiIQ7jKXeEe 1EQaxY8mIagtUwjrjA4RWlrW4vz2FGLRLT/KxMIa8XZs2+fSG7lSMSm1cYnCRTfa uUBeesuVoiMM2X1UjOh6 =++u7 -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls. Date: Mon, 07 Dec 2015 17:16:23 -0800 Message-ID: <87bna1d9js.fsf@eliezer.anholt.net> References: <1449002158-19156-1-git-send-email-eric@anholt.net> <1449002158-19156-3-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1602817850==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel List-Id: dri-devel@lists.freedesktop.org --===============1602817850== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Emil Velikov writes: > Hi Eric, > > A couple of suggestions/requests on the UAPI header side > > On 1 December 2015 at 20:35, Eric Anholt wrote: > >> --- /dev/null >> +++ b/include/uapi/drm/vc4_drm.h > >> +#include >> + > Can we make this a "drm.h" ? Nope. include/uapi/drm/vc4_drm.h:27:17: fatal error: drm.h: No such file or directory and none of the drivers do, either. >> +struct drm_vc4_create_bo { >> + uint32_t size; >> + uint32_t flags; >> + /** Returned GEM handle for the BO. */ >> + uint32_t handle; >> + uint32_t pad; > ... and not use the stdint.h types but __{s,u}* through the file. > > I'd rather than not nag why we want/need those, but if you prefer I > can repeat myself/others. I've switched to using the special types. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJWZi9nAAoJELXWKTbR/J7oIigP/iqFpvIHHNbjrRpbcPmPhJ3b EWgPVpGL4e7qa4zXMIPYDYglaWfCA3EXO9CKy/TQ+CgQOEvOnJb7x8kl9iK3+QyJ ZBu5/03ztp+9usCbKZ6EIaN9ZIFf4U4OEanxzL+BGJqTDg1NCou4FuifukY8ypid RNg0KRWng7GzyBBIBiIm69ax133q/CnnF6S3nXGzuqZLzw18lMbUwSYnSDcib1jk vBxiKxafqe5mvY16/0gmjsvH7UoWb+1kIveRPaRKgp6CQXQbvDFTN+JZaCuAEGmx t+HYBySnaroRCrM1yxAbedJPOtZP0Zo73MCxY7j85I6qiNLvmULqtwzRMB+vF4qi pKuCqVU1T7UxZIafZ8bGnuEZ7bbFEmS8M8exA6VwxgUAcs4DuYdGnshuLQ+9G7XL YbAXYLKnuoJcbknVMmRT+aVeW2wU4/DdkG+DvCuvA2mO5tycWFkn6Ga+A7Ys0Z8f K/vDOOH8FMRGnaDA0EkXREHaSD3bvuKLC1t+hD7z3KkYPt6yicTDQD4q+GhYxxq/ wlIsRblw7TQy+tAwJdRzvbv/ssy4ZKeAGmrs23dTe6sqXUbh/UV7QjiIQ7jKXeEe 1EQaxY8mIagtUwjrjA4RWlrW4vz2FGLRLT/KxMIa8XZs2+fSG7lSMSm1cYnCRTfa uUBeesuVoiMM2X1UjOh6 =++u7 -----END PGP SIGNATURE----- --=-=-=-- --===============1602817850== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1602817850==--