From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47633)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nikunj@linux.vnet.ibm.com>) id 1YdAqE-0004Ad-Rt
	for qemu-devel@nongnu.org; Wed, 01 Apr 2015 01:05:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nikunj@linux.vnet.ibm.com>) id 1YdAq2-0008B3-F5
	for qemu-devel@nongnu.org; Wed, 01 Apr 2015 01:05:26 -0400
Received: from e28smtp01.in.ibm.com ([122.248.162.1]:47055)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nikunj@linux.vnet.ibm.com>) id 1YdAq1-00089C-R0
	for qemu-devel@nongnu.org; Wed, 01 Apr 2015 01:05:14 -0400
Received: from /spool/local
	by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <nikunj@linux.vnet.ibm.com>;
	Wed, 1 Apr 2015 10:35:10 +0530
From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
In-Reply-To: <1427825872.5567.177.camel@redhat.com>
References: <1427352132-1762-1-git-send-email-nikunj@linux.vnet.ibm.com>
	<1427825872.5567.177.camel@redhat.com>
Date: Wed, 01 Apr 2015 10:35:06 +0530
Message-ID: <87bnj8tp4t.fsf@abhimanyu.in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 1/2] vfio-pci: add flag to identify vfio
	pci device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: aik@ozlabs.ru, david@gibson.dropbear.id.au, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de

Alex Williamson <alex.williamson@redhat.com> writes:

> On Thu, 2015-03-26 at 12:12 +0530, Nikunj A Dadhania wrote:
>> From PCIDevice there is no way to know if the device has a backing
>> vfio device.
>> 
>> sPAPR guests inherits the "ibm,loc-code" from the pci pass through
>> device in hypervisor. This helps in identifying the device if there is
>> any failures using this "ibm,loc-code" for RAS capabilities.
>> 
>> CC: Alex Williamson <alex.williamson@redhat.com>
>> CC: Alexander Graf <agraf@suse.de>
>> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
>> ---
>>  hw/vfio/pci.c        | 2 ++
>>  include/hw/pci/pci.h | 2 ++
>>  2 files changed, 4 insertions(+)
>
> I agree with the other comments on this series, the vfio information can
> be found using existing object and property functions.  Nak to the vfio
> related changes. 

Yes, I have dropped this patch for the series.

http://lists.gnu.org/archive/html/qemu-devel/2015-03/msg05940.html

There is discussion around the patch, regarding doing PCI enumeration in
Qemu in place of SLOF.

> Also, please us cover letters for multi-patch series.

Sure, will take care about it.

Regards,
Nikunj