From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbBDc-0001HS-Gy for qemu-devel@nongnu.org; Thu, 26 Mar 2015 13:05:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbBDY-0005Vt-No for qemu-devel@nongnu.org; Thu, 26 Mar 2015 13:05:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbBDY-0005Vp-HX for qemu-devel@nongnu.org; Thu, 26 Mar 2015 13:05:16 -0400 From: Markus Armbruster References: <1427227433-5030-1-git-send-email-eblake@redhat.com> <1427227433-5030-16-git-send-email-eblake@redhat.com> Date: Thu, 26 Mar 2015 18:05:12 +0100 In-Reply-To: <1427227433-5030-16-git-send-email-eblake@redhat.com> (Eric Blake's message of "Tue, 24 Mar 2015 14:03:40 -0600") Message-ID: <87bnjfy9iv.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v5 15/28] qapi: Add tests of redefined expressions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, lcapitulino@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com Eric Blake writes: > Demonstrate that the qapi generator doesn't deal very well with > redefined expressions. At the parse level, they are silently > accepted; and while the testsuite just stops at parsing, I've > further tested that many of them cause generator crashes or > invalid C code if they were appended to qapi-schema-test.json. > A later patch will tighten things up and adjust the testsuite > to match. > > Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster