From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40728)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1XRLRJ-0004MO-Aa
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 09:26:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1XRLRC-00017S-KU
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 09:26:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33700)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1XRLRC-00017K-Dj
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 09:26:26 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1410265809-27247-5-git-send-email-pbonzini@redhat.com> (Paolo
	Bonzini's message of "Tue, 9 Sep 2014 14:30:03 +0200")
References: <1410265809-27247-1-git-send-email-pbonzini@redhat.com>
	<1410265809-27247-5-git-send-email-pbonzini@redhat.com>
Date: Tue, 09 Sep 2014 15:26:22 +0200
Message-ID: <87bnqp2add.fsf@troll.troll>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 04/10] pcspk: adding vmstate for
	save/restore
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: amit.shah@redhat.com, qemu-devel@nongnu.org, Pavel.Dovgaluk@ispras.ru, dgilbert@redhat.com

Paolo Bonzini <pbonzini@redhat.com> wrote:
> From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
>
> VMState added by this patch preserves correct
> loading of the PC speaker device state.
>
> This breaks migration to 2.1 and earlier.
>
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

This should only be added for new machine types, right?

Later, Juan.

> @@ -192,6 +203,7 @@ static void pcspk_class_initfn(ObjectClass *klass, void *data)
>  
>      dc->realize = pcspk_realizefn;
>      set_bit(DEVICE_CATEGORY_SOUND, dc->categories);
> +    dc->vmsd = &vmstate_spk;
>      dc->props = pcspk_properties;
>      /* Reason: pointer property "pit", realize sets global pcspk_state */
>      dc->cannot_instantiate_with_device_add_yet = true;