From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDXZ6-0003V8-2G for qemu-devel@nongnu.org; Wed, 12 Feb 2014 06:01:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDXZ0-0004R0-Gv for qemu-devel@nongnu.org; Wed, 12 Feb 2014 06:01:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDXZ0-0004Qw-9c for qemu-devel@nongnu.org; Wed, 12 Feb 2014 06:01:10 -0500 From: Markus Armbruster References: <20140212091307.1972.7704.malonedeb@soybean.canonical.com> <20140212091307.1972.7704.malonedeb@soybean.canonical.com> Date: Wed, 12 Feb 2014 12:01:02 +0100 In-Reply-To: <20140212091307.1972.7704.malonedeb@soybean.canonical.com> (dcb's message of "Wed, 12 Feb 2014 09:13:07 -0000") Message-ID: <87bnycegsx.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [Bug 1279257] [NEW] [hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) == 0x1' is always false. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bug 1279257 <1279257@bugs.launchpad.net> Cc: qemu-devel@nongnu.org dcb <1279257@bugs.launchpad.net> writes: > Public bug reported: > > Source code is > > } else if ((buf[1] & 4) == 1) { > > Suggest code rework. I found this bug by running > static analyser cppcheck over the source code. > > I also checked the latest code on the web and the > bug exists there also. > > ** Affects: qemu > Importance: Undecided > Status: New Patch is in scsi-next: https://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg04066.html